Bug 102882 - Folder.java sets/gets a static 'wasNew' variable in beforeSave/afterSave methods
Summary: Folder.java sets/gets a static 'wasNew' variable in beforeSave/afterSave methods
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise CMS
Classification: Retired
Component: other
Version: 6.0
Hardware: All
OS: Linux
medium
high
Target Milestone: ---
Assignee: ccm-bugs-list
QA Contact: Jon Orris
URL:
Whiteboard:
Depends On:
Blocks: 108447
TreeView+ depends on / blocked
 
Reported: 2003-08-22 09:54 UTC by Daniel Berrangé
Modified: 2007-04-18 16:57 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-02 17:42:19 UTC
Embargoed:

Attachments (Terms of Use)

Description Daniel Berrangé 2003-08-22 09:54:39 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 Galeon/1.2.9 (X11; Linux i686; U;) Gecko/20030314

Description of problem:
Folder.java is setting & getting a static 'm_wasNew' variable in its
beforeSave/afterSave methods. This should obviously /not/  be a static variable
unless we can guarentee that there are no concurrent saves of Folder objects ;-)


Version-Release number of selected component (if applicable):


How reproducible:
Sometimes

Steps to Reproduce:
1. Get two threads to save a folder at the same time

Actual Results:  One thread does the wrong thing in afterSave.

Expected Results:  Both threads execute afterSave correctly.

Additional info:
Comment 1 Daniel Berrangé 2003-08-22 10:00:43 UTC 
cf featurezilla 102883
Comment 2 Richard Li 2003-12-23 20:38:39 UTC 
This was fixed in the land of the test-search branch (@35351).
Comment 3 Daniel Berrangé 2004-01-05 10:02:25 UTC 
Opps, a little confusion about releases. When I opened this ticket,
'nightly' was still referring to Troika (6.0). That branch is still
broken:

dan@camden$ grep m_wasNew cms/6.0/src/com/arsdigita/cms/Folder.java 
    private static boolean m_wasNew;
        m_wasNew = isNew();
        if (m_wasNew) {
dan@camden$
Comment 4 Richard Li 2004-01-05 14:18:16 UTC 
not rc0
Comment 5 Daniel Berrangé 2006-09-02 17:42:19 UTC 
Closing old tickets
Note You need to log in before you can comment on or make changes to this bug.