Bug 1028871 - gluster-cli: Format the output of 'gluster pool list' properly
Summary: gluster-cli: Format the output of 'gluster pool list' properly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ---
Assignee: Vijaikumar Mallikarjuna
QA Contact:
URL:
Whiteboard:
Depends On: 987511
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-11 06:06 UTC by Vijaikumar Mallikarjuna
Modified: 2016-05-11 22:47 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of: 987511
Environment:
Last Closed: 2014-11-11 08:24:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2013-11-11 06:38:47 UTC
REVIEW: http://review.gluster.org/6245 (cli: Set the o/p width of hostname to 8 characters) posted (#1) for review on master by Vijaikumar M (vmallika)

Comment 2 Anand Avati 2013-11-11 18:23:09 UTC
COMMIT: http://review.gluster.org/6245 committed in master by Anand Avati (avati) 
------
commit 27935ee84c484fff3d8d29218c197812701957ed
Author: Vijaykumar M <vmallika>
Date:   Mon Nov 11 12:05:55 2013 +0530

    cli: Set the o/p width of hostname to 8 characters
    
    Change-Id: I91dcb19ba4d31c17e6041155c0e59af457b87f1b
    BUG: 1028871
    Signed-off-by: Vijaykumar M <vmallika>
    Reviewed-on: http://review.gluster.org/6245
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 3 Niels de Vos 2014-04-17 11:50:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Vijaikumar Mallikarjuna 2014-06-20 10:24:19 UTC
Downstream bug# 987511 is re-opened with failed QA:

>M S Vishwanath Bhat 2014-06-16 08:25:11 EDT
>Looks like it is not fixed completely.
>
>[root@rhsauto023 ~]# gluster pool list
>UUID                                    Hostname        State
>e3aea7f5-7cce-43a5-958d-668723481746    rhsauto024.lab.eng.blr.redhat.com       >Connected 
>74c3fbc5-cd98-4e56-96ad-581c6ccd909b    rhsauto028.lab.eng.blr.redhat.com       >Connected 
>52e74907-b256-41c1-b2dc-f1ae3df4433d    rhsauto029.lab.eng.blr.redhat.com       >Connected 
>44c5258e-2db1-482a-9521-1d768b7c7df5    localhost       Connected 
>
>
>But now it looks better than before. But it would be great to have last thing >here fixed.
>
>UUID                                    Hostname        State
>e3aea7f5-7cce-43a5-958d-668723481746    rhsauto024.lab.eng.blr.redhat.com       >Connected 
>44c5258e-2db1-482a-9521-1d768b7c7df5    10.70.36.253    Connected 
>52e74907-b256-41c1-b2dc-f1ae3df4433d    rhsauto029.lab.eng.blr.redhat.com       >Connected 
>74c3fbc5-cd98-4e56-96ad-581c6ccd909b    localhost       Connected 
>
>
>Re-opening it for now. But this is very low priority. So if you think that >output is just fine, please move the bug to verified.
>
>
>Tested in version: glusterfs-3.6.0.14-1.el6rhs.x86_64

Comment 5 Anand Avati 2014-06-20 10:24:56 UTC
REVIEW: http://review.gluster.org/8127 (cli: Set the o/p width of hostname to 32 characters) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 6 Anand Avati 2014-06-23 06:19:51 UTC
REVIEW: http://review.gluster.org/8127 (cli: Set the o/p width of hostname to 32 characters) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 7 Anand Avati 2014-06-23 06:22:09 UTC
REVIEW: http://review.gluster.org/8127 (cli: Format the hostname column properly) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 8 Anand Avati 2014-06-24 04:59:29 UTC
REVIEW: http://review.gluster.org/8127 (cli: Format the hostname column properly in the 'pool list' o/p) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 9 Anand Avati 2014-07-02 11:04:39 UTC
COMMIT: http://review.gluster.org/8127 committed in master by Kaushal M (kaushal) 
------
commit ca6980d0828a6e7f38d7638a3b99db5d9be36260
Author: Vijaikumar M <vmallika>
Date:   Fri Jun 20 15:40:46 2014 +0530

    cli: Format the hostname column properly in the 'pool list' o/p
    
    In the pool list output, if the hostname is lengthier, then the indentation was not proper.
    
    Solution:
    1) get the full list of hostnames first (prior to display)
    2) Determine the maximum length of the hostname strings from that
    3) Create an appropriate display padding amount, using the length from (2)
    
    Change-Id: Icc3724975a5e30b02b8e06db709930cbac5e0875
    BUG: 1028871
    Signed-off-by: Vijaikumar M <vmallika>
    Reviewed-on: http://review.gluster.org/8127
    Tested-by: Justin Clift <justin>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Kaushal M <kaushal>

Comment 10 Niels de Vos 2014-09-22 12:32:39 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 11 Niels de Vos 2014-11-11 08:24:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.