Hide Forgot
Description of problem: Every action that accepts a password on the command line should be able to accept it also using safer means: Interactively, using an environment variable, reading from a file. I am currently opening this bug for setVmTicket in bug #1021902 but it's applicable elsewhere in vdsClient.
setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.
What vdsCli commands accepts password ?
discoverST connectStorageServer setVmTicket validateStorageServerConnection disconnectStorageServer desktopLogin are the commands that get password as part of theirs parameters
oVirt gerrit 24733
This is an automated message. Re-targeting all non-blocker bugs still open on 3.4.0 to 3.4.1.
Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA.
tested with vdsm-4.17.15-0.el7ev.noarch failed with use auth=file:/root/file #echo "password" > /root/file #vdsClient -s 0 setVmTicket <vmID> - 120 -- auth=file:/root/file after that it's not possible login to display via vncviewer with password "password". There is a problem with reading a file, readed file has one more character (end of line). 'env' and 'pass' working properly.
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
I checked the code and this scenario is covered by unit tests so I attempted to reproduce the issue using latest master (there were no changes for this functionality). I host deployed vdsm, configured nfs storage and created a vm. After that I run commands as described in comment #9 and I got following output: [root@f20 hosted]# vdsClient -s 0 setVmTicket 8e2456e6-cdf6-418f-893b-c714068e2fc8 - 120 -- auth=file:/root/file code = 0 message = 'Done' Please note that I run the commands as root. Please make sure that you have correct permissions and if you still see the issue please provide steps to reproduce. Otherwise I am going to close this BZ.
I did an update engine & host to vdsm-4.17.17-0.el7ev.noarch and now everything is working. So I move it to verified Verified in vdsm-4.17.17-0.el7ev.noarch