Spec URL: http://jdornak.fedorapeople.org/python3-openid.spec SRPM URL: http://jdornak.fedorapeople.org/python3-openid-3.0.2-1.fc20.src.rpm Description: This started out as a fork of the Python OpenID library, with changes to make it Python 3 compatible. It's now a port of that library, including cleanups and updates to the code in general. Fedora Account System Username: jdornak
Created attachment 838378 [details] /tmp/ Add patch for certain cases where parseXRDS gets passed unicode string instead of bytes instance
Thank You, I have included Your patch.
- The License field should use short license name [0], so in this case it should prolly be "ASL 2.0". - Maybe I'm missing something, but why do you list all the directories and *.py[co] files in %files instead of just using: %{python3_sitelib}/openid/ %{python3_sitelib}/python3_openid-%{version}-py3.*.egg-info [0] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Valid_License_Short_Names
To be honest, I have listed the directories just because I was asked to do it in another review (#1036396). It is probably aimed to ensure that every new directory in future versions, which may possibly be bundled library, requires packager's attention. I have updated the version in the spec file.
(In reply to Jakub Dorňák from comment #4) > To be honest, I have listed the directories just because I was asked to do > it in another review (#1036396). > It is probably aimed to ensure that every new directory in future versions, > which may possibly be bundled library, requires packager's attention. I see. Not what I do, but it can't hurt I s'ppose. Looking at the %check output [0], I think it would be good to add python3-django and python3-httplib2 to BuildRequires (and eventually the others as well, once they get python3 package), so that the tests working with those will be executed too, however these tests currently fail. From what I can tell it seems to be caused by incorrect/incomplete porting of the tests to python3, so it's not that big of a deal. The spec looks fine otherwise, so I'll APPROVE this, but please try to resolve this. [0] http://kojipkgs.fedoraproject.org//work/tasks/8585/6488585/build.log
Yes, You are right, but since this project is fork of former python2 project, most of the tests themselves are not valid python3 code yet, so the tests would fail even if the tested code was OK. §:o( Therefore it is temporary intention to limit the tests. However, I will add some comment to the spec file, for this situation to be clarified.
New Package SCM Request ======================= Package Name: python3-openid Short Description: Python 3 port of the python-openid library Owners: jdornak Branches: f20 InitialCC:
Git done (by process-git-requests).
Closing this as it seems to be resolved, feel free to reopen if necessary. :)