Created attachment 833669 [details] log_collector Description of problem: If user tries to create new VM with 5 vNICs and there only 3 MACs left in MAC Address Pool. VM gets created only with 3 vNICs which is fine, 2013-12-06 15:59:04,731 ERROR [org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand] (pool-4-thread-46) [4f20698a] Command org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand throw Vdc Bll exception. With error message VdcBLLException: MAC_POOL_NO_MACS_LEFT (Failed with error MAC_POOL_NO_MACS_LEFT and code 5012) engine just should raise full screen warning, same one it raises when user tries to add vNIC via Virtual Machines -> your VM -> Network interfaces -> New 2013-12-06 16:02:22,970 WARN [org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand] (ajp-/127.0.0.1:8702-11) [e83840f] CanDoAction of action AddVmInterface failed. Reasons:VAR__TYPE__INTERFACE,VAR__ACTION__ADD,MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES Version-Release number of selected component (if applicable): Red Hat Enterprise Virtualization Manager Version: 3.3.0-0.38.rc.el6ev How reproducible: 100% Steps to Reproduce: 1. restrict mac pool range to 3 MACs e.g. engine-config --set MacPoolRanges=00:1A:4A:C0:3F:20-00:1A:4A:C0:3F:22 and restart engine in order to apply the change 2. Virtual Machines -> New -> add 5 vNICs -> confirm the dialog Actual results: VM gets created without warning there is a note in events Failed to add Interface nic5 (VirtIO) to VM VM_5nics. (User: admin@internal) Expected results: VM gets created with more visible warning (see description) Additional info: 2013-12-06 15:59:04,731 ERROR [org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand] (pool-4-thread-46) [4f20698a] Command org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand throw Vdc Bll exception. With error message VdcBLLException: MAC_POOL_NO_MACS_LEFT (Failed with error MAC_POOL_NO_MACS_LEFT and code 5012) 2013-12-06 16:02:22,970 WARN [org.ovirt.engine.core.bll.network.vm.AddVmInterfaceCommand] (ajp-/127.0.0.1:8702-11) [e83840f] CanDoAction of action AddVmInterface failed. Reasons:VAR__TYPE__INTERFACE,VAR__ACTION__ADD,MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES
Martin, just so I understand: so a warning appears in the audit log about the interfaces not being created? If that is the case, this isn't a bug in my opinion. If 3 out of 5 interfaces are created, and the administrator is notified about the other 2 in the audit log, I think it's fine. The main action here is creating the VM, which succeeds. Some interfaces are created, so that's not a real failure either. So I don't see a case for a popup window, batch operations like this, where some can succeed and some can fail, are perfect candidates to use the audit log to notify of failures.
(In reply to Lior Vernia from comment #2) > Martin, just so I understand: so a warning appears in the audit log about > the interfaces not being created? If that is the case, this isn't a bug in > my opinion. If 3 out of 5 interfaces are created, and the administrator is > notified about the other 2 in the audit log, I think it's fine. > > The main action here is creating the VM, which succeeds. Some interfaces are > created, so that's not a real failure either. So I don't see a case for a > popup window, batch operations like this, where some can succeed and some > can fail, are perfect candidates to use the audit log to notify of failures. Technically you are right, but think of it from user point of view, you want to create VM with 5NICs and you get 3 just with "silent" note in event log which can be represented by one visible line somewhere on the bottom of the screen. I think the warning should be louder. In the end you have perfect VM which might lack connectivity to important networks which makes it "useless" anyways.
Nir? Thoughts?
From a user POV, I agree that a clear error/warning message is preferable in this case.
Martin, isn't this actually a duplicate of Bug 1066461 (that was opened later)? A dialog is in fact displayed, it is just hidden behind the Guide Me dialog.
this one was found on 3.3, but if the fix is going to be only in 3.4 then they are in fact duplicate
*** This bug has been marked as a duplicate of bug 1066461 ***