Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/modem-manager-gui.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/modem-manager-gui-0.0.16-2.fc20.src.rpm Description: This program is simple graphical interface for Modem Manager daemon dbus interface. Current features: - View device information: Operator name, Mode, IMEI, IMSI, Signal level. - Send and receive SMS messages with long massages concatenation and store messages in database. - Send USSD requests and read answers in GSM7 and UCS2 formats converted to system UTF8 charset. - Scan available mobile networks. Fedora Account System Username: mariobl This tool works fine so far, but produces a SELinux message. See bug #1047021.
Will review when no blocks stay here. Note: %{_libdir}/%{name}/* You forgot to own %{_libdir}/%{name} itself.
OK, I've fixed the folder ownership and some other things. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/modem-manager-gui.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/modem-manager-gui-0.0.16-3.fc20.src.rpm Regarding the SELinux thing, I'm not sure if it affects this package actually. The error message is caused by a access from Modemmanager, not modem-manager-gui. Of course, it has to be fixed, but it is up to the Modemmanager and SELinux packagers to do that.
The fact is that selinux is blocking modemmanager from working normally but not this gui frontend. So I think it's not a blocker. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)". Detailed output of licensecheck: GPL (v3 or later) ----------------- modem-manager-gui-0.0.16/src/addressbooks.c modem-manager-gui-0.0.16/src/addressbooks.h modem-manager-gui-0.0.16/src/ayatana.c modem-manager-gui-0.0.16/src/ayatana.h modem-manager-gui-0.0.16/src/encoding.c modem-manager-gui-0.0.16/src/encoding.h modem-manager-gui-0.0.16/src/libpaths.c modem-manager-gui-0.0.16/src/libpaths.h modem-manager-gui-0.0.16/src/main.c modem-manager-gui-0.0.16/src/main.h modem-manager-gui-0.0.16/src/mmguicore.c modem-manager-gui-0.0.16/src/mmguicore.h modem-manager-gui-0.0.16/src/modules/mm06.c modem-manager-gui-0.0.16/src/modules/mm07.c modem-manager-gui-0.0.16/src/modules/nm09.c modem-manager-gui-0.0.16/src/modules/pppd245.c modem-manager-gui-0.0.16/src/netlink.c modem-manager-gui-0.0.16/src/netlink.h modem-manager-gui-0.0.16/src/notifications.c modem-manager-gui-0.0.16/src/notifications.h modem-manager-gui-0.0.16/src/settings.c modem-manager-gui-0.0.16/src/settings.h modem-manager-gui-0.0.16/src/smsdb.c modem-manager-gui-0.0.16/src/smsdb.h modem-manager-gui-0.0.16/src/strformat.c modem-manager-gui-0.0.16/src/strformat.h modem-manager-gui-0.0.16/src/trafficdb.c modem-manager-gui-0.0.16/src/trafficdb.h modem-manager-gui-0.0.16/src/ussdlist.c modem-manager-gui-0.0.16/src/ussdlist.h [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/bn_BD, /usr/share/locale/bn_BD/LC_MESSAGES --> File a bug against filesystem or remove that dir. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/bn_BD/LC_MESSAGES, /usr/share/locale/bn_BD [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: modem-manager-gui-0.0.16-3.fc21.i686.rpm modem-manager-gui-0.0.16-3.fc21.src.rpm modem-manager-gui.i686: W: spelling-error %description -l en_US dbus -> dubs, bus, buds modem-manager-gui.i686: W: spelling-error %description -l en_US charset -> char set, char-set, catharses modem-manager-gui.src: W: spelling-error %description -l en_US dbus -> dubs, bus, buds modem-manager-gui.src: W: spelling-error %description -l en_US charset -> char set, char-set, catharses 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint modem-manager-gui modem-manager-gui.i686: W: spelling-error %description -l en_US dbus -> dubs, bus, buds modem-manager-gui.i686: W: spelling-error %description -l en_US charset -> char set, char-set, catharses 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- modem-manager-gui (rpmlib, GLIBC filtered): libatk-1.0.so.0 libc.so.6 libcairo-gobject.so.2 libcairo.so.2 libgdbm.so.4 libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-3.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 rtld(GNU_HASH) Provides -------- modem-manager-gui: application() application(modem-manager-gui.desktop) modem-manager-gui modem-manager-gui(x86-32) Unversioned so-files -------------------- modem-manager-gui: /usr/lib/modem-manager-gui/modules/modcm_nm09.so modem-manager-gui: /usr/lib/modem-manager-gui/modules/modcm_pppd245.so modem-manager-gui: /usr/lib/modem-manager-gui/modules/modmm_mm06.so modem-manager-gui: /usr/lib/modem-manager-gui/modules/modmm_mm07.so Source checksums ---------------- http://download.tuxfamily.org/gsf/source/modem-manager-gui-0.0.16.tar.gz : CHECKSUM(SHA256) this package : 46030cb8deb4aeb312bf82f6bd2f98e6487faeab7db311aced650a7381625a37 CHECKSUM(SHA256) upstream package : 46030cb8deb4aeb312bf82f6bd2f98e6487faeab7db311aced650a7381625a37 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn modem-manager-gui-0.0.16-3.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG ----------------- Nearly approved.
I've removed the bn_BD locale in %prep. Besides that, I've added summary, description and man page in German. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/modem-manager-gui.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/modem-manager-gui-0.0.16-4.fc20.src.rpm
PACKAGE APPROVED. BTW, if a locale is not supported by Fedora filesystem, should we report it as a bug?
(In reply to Christopher Meng from comment #5) > BTW, if a locale is not supported by Fedora filesystem, should we report it > as a bug? Yes, indeed... I was only looking for the content of the filesystem package, and there was nothing for the bn_BD locale. But while having a look on my own system, I found four files: [mariobl@localhost LC_MESSAGES]$ ls policycoreutils.mo system-config-services.mo system-config-date.mo system-config-users.mo The parent folders LC_MESSAGES and bn_BD stay unowned. It is worth a bug report, I've done this: https://bugzilla.redhat.com/show_bug.cgi?id=1048327
Many thanks for the review and approval! New Package SCM Request ======================= Package Name: modem-manager-gui Short Description: Graphical interface for ModemManager Owners: mariobl Branches: f20 InitialCC:
Git done (by process-git-requests).
modem-manager-gui-0.0.16-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/modem-manager-gui-0.0.16-4.fc20
modem-manager-gui-0.0.16-4.fc20 has been pushed to the Fedora 20 testing repository.
modem-manager-gui-0.0.16-4.fc20 has been pushed to the Fedora 20 stable repository.