Bug 1047602 - Review Request: php-phpseclib-crypt-des - Pure-PHP implementation of DES
Summary: Review Request: php-phpseclib-crypt-des - Pure-PHP implementation of DES
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1047596
Blocks: 1047609
TreeView+ depends on / blocked
 
Reported: 2014-01-01 03:14 UTC by Adam Williamson
Modified: 2014-02-25 18:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-14 19:51:01 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (8.63 KB, text/plain)
2014-01-07 08:45 UTC, Remi Collet
no flags Details
review.txt (7.15 KB, text/plain)
2014-01-07 08:46 UTC, Remi Collet
no flags Details

Description Adam Williamson 2014-01-01 03:14:36 UTC
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-DES/php-phpseclib-Crypt-DES.spec
SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-DES/php-phpseclib-Crypt-DES-0.3.5-1.fc21.src.rpm
Description: Uses mcrypt, if available, and an internal implementation, otherwise.
Fedora Account System Username: adamwill

Comment 2 Remi Collet 2014-01-07 08:45:31 UTC
Created attachment 846513 [details]
phpci.log

phpcompatinfo version 2.26.0.

Comment 3 Remi Collet 2014-01-07 08:46:10 UTC
Created attachment 846514 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047602

Comment 4 Remi Collet 2014-01-07 08:46:37 UTC
[x]: Requires correct, justified where necessary.
  Optional php-mcrypt, packager choice.

[-]: If the source package does not include license text(s) as a separate file
  Included in the single source header

Comment 5 Remi Collet 2014-01-07 14:43:24 UTC
Sorry I miss that one:

[!]: Requires correct, justified where necessary.
  From package.xml, optional so packager choice
    php-mcrypt
  From phpci.log (inconditionally used in Crypt_DES::setPassword()
    php-pear(phpseclib.sourceforge.net/Crypt_Hash)

Comment 7 Adam Williamson 2014-01-09 22:30:41 UTC
Stealth updated to also drop ownership of the Crypt/ dir.

Comment 8 Remi Collet 2014-01-10 06:37:18 UTC
[x]: Requires correct, justified where necessary.
[x]: Package does not own files or directories owned by other packages.

== APPROVED ==

Comment 9 Adam Williamson 2014-01-10 20:01:15 UTC
New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-des
Short Description: Pure-PHP implementation of DES
Owners: adamwill
Branches: f20 el6
InitialCC:

Comment 10 Gwyn Ciesla 2014-01-10 20:15:55 UTC
Git done (by process-git-requests).

Comment 11 Adam Williamson 2014-01-14 19:51:01 UTC
Building for Rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=6405085

Comment 12 Adam Williamson 2014-02-24 03:24:22 UTC
Package Change Request
======================
Package Name: php-phpseclib-net-ssh2
New Branches: f19 epel7

Comment 13 Adam Williamson 2014-02-24 03:25:19 UTC
Correction:

Package Change Request
======================
Package Name: php-phpseclib-crypt-des
New Branches: f19 epel7

Comment 14 Gwyn Ciesla 2014-02-24 13:22:21 UTC
No owners specified.

Comment 15 Adam Williamson 2014-02-25 18:24:58 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-des
New Branches: f19 epel7
Owners: adamwill

Comment 16 Gwyn Ciesla 2014-02-25 18:48:18 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.