Bug 1047609 - Review Request: php-phpseclib-crypt-tripledes - Pure-PHP implementation of Triple DES
Summary: Review Request: php-phpseclib-crypt-tripledes - Pure-PHP implementation of Tr...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1047602
Blocks: 1047611
TreeView+ depends on / blocked
 
Reported: 2014-01-01 03:26 UTC by Adam Williamson (Red Hat non-Fedora)
Modified: 2014-02-25 18:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-26 01:46:58 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (8.50 KB, text/plain)
2014-01-07 14:44 UTC, Remi Collet 		no flags Details
review.txt (7.76 KB, text/plain)
2014-01-07 14:45 UTC, Remi Collet 		no flags Details
View All

Description Adam Williamson (Red Hat non-Fedora) 2014-01-01 03:26:54 UTC 
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-TripleDES/php-phpseclib-Crypt-TripleDES.spec
SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-TripleDES/php-phpseclib-Crypt-TripleDES-0.3.5-1.fc21.src.rpm
Description: Uses mcrypt, if available, and an internal implementation, otherwise. Operates in the EDE3 mode (encrypt-decrypt-encrypt).
Fedora Account System Username: adamwill
Comment 1 Adam Williamson (Red Hat non-Fedora) 2014-01-05 06:24:50 UTC 
Updated:

https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes.spec
https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes-0.3.5-2.fc21.src.rpm
Comment 2 Remi Collet 2014-01-07 14:44:34 UTC 
Created attachment 846709 [details]
phpci.log

phpcompatinfo version 2.26.0.
Comment 3 Remi Collet 2014-01-07 14:45:21 UTC 
Created attachment 846710 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047609
Comment 4 Remi Collet 2014-01-07 14:45:52 UTC 
[!]: Requires correct, justified where necessary.
  From package.xml, optional so packager choice
    php-mcrypt
  From phpci.log (inconditionally used in Crypt_TripleDES::setPassword()
    php-pear(phpseclib.sourceforge.net/Crypt_Hash)

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
  License text included in the single source header.
Comment 5 Adam Williamson (Red Hat non-Fedora) 2014-01-09 22:34:27 UTC 
Updated:

https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes.spec
https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes-0.3.5-3.fc21.src.rpm
Comment 6 Remi Collet 2014-01-10 06:41:31 UTC 
[x]: Requires correct, justified where necessary.
[x]: Package does not own files or directories owned by other packages.
Comment 7 Adam Williamson (Red Hat non-Fedora) 2014-01-17 02:30:54 UTC 
New Package SCM Request
=======================
Package Name: php-phpseclib-Crypt-TripleDES
Short Description: Pure-PHP implementation of Triple DES
Owners: adamwill
Branches: f20 el6 el7
InitialCC:
Comment 8 Adam Williamson (Red Hat non-Fedora) 2014-01-17 02:32:17 UTC 
Sorry, correction:

New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-tripledes
Short Description: Pure-PHP implementation of Triple DES
Owners: adamwill
Branches: f20 el6 el7
InitialCC:

(note lower-case package name)
Comment 9 Gwyn Ciesla 2014-01-17 13:03:50 UTC 
WARNING: Invalid branch el7 requested: use epel7
WARNING: Requested package name php-phpseclib-crypt-tripledes doesn't match
bug summary php-phpseclib-Crypt-TripleDES: fix.
Comment 10 Adam Williamson (Red Hat non-Fedora) 2014-01-17 23:00:34 UTC 
New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-tripledes
Short Description: Pure-PHP implementation of Triple DES
Owners: adamwill
Branches: f20 el6 epel7
InitialCC:
Comment 11 Gwyn Ciesla 2014-01-21 14:06:38 UTC 
Git done (by process-git-requests).
Comment 12 Adam Williamson (Red Hat non-Fedora) 2014-01-26 01:46:58 UTC 
Built for Rawhide.
Comment 13 Adam Williamson (Red Hat non-Fedora) 2014-02-24 03:24:35 UTC 
Package Change Request
======================
Package Name: php-phpseclib-crypt-tripledes
New Branches: f19
Comment 14 Gwyn Ciesla 2014-02-24 13:28:29 UTC 
No owners specified.
Comment 15 Adam Williamson (Red Hat non-Fedora) 2014-02-25 18:26:16 UTC 
Package Change Request
======================
Package Name: php-phpseclib-crypt-tripledes
New Branches: f19
Owners: adamwill
Comment 16 Gwyn Ciesla 2014-02-25 18:50:43 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.