Bug 1047702 (TCLCL) - Review Request: tclcl - Tcl/C++ interface
Summary: Review Request: tclcl - Tcl/C++ interface
Keywords:
Status: CLOSED NOTABUG
Alias: TCLCL
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: OTcl
Blocks: FE-DEADREVIEW ns2
TreeView+ depends on / blocked
 
Reported: 2014-01-01 21:50 UTC by Mosaab Alzoubi
Modified: 2020-08-10 00:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:48:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
failing build log on rawhide/i386 (16.24 KB, text/plain)
2015-04-06 17:59 UTC, Zbigniew Jędrzejewski-Szmek
no flags Details

Description Mosaab Alzoubi 2014-01-01 21:50:49 UTC
Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-1.oji.fc19.src.rpm
Description:
TclCL (Tcl with classes) is a Tcl/C++ interface used by Mash,
vic, vat, rtp_play, ns, and nam. It provides a layer of C++
glue over OTcl. 

Fedora Account System Username: moceap

Comment 1 Mosaab Alzoubi 2014-02-11 15:17:56 UTC
- Resort Descripsions.
- Fix -devel to be arched.
- Decrease %%configure line
- Remove .a library.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-2.fc20.src.rpm

Comment 2 Mosaab Alzoubi 2014-02-11 15:27:34 UTC
- Undo remove library, it's needed by ns2.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-3.fc20.src.rpm

Comment 3 Michael Schwendt 2014-02-11 15:55:52 UTC
> %description devel
> This package contains libraries and header files for
> developing applications that use %{name}.

Currently, the package does not contain any libraries.


> Group: Development/Languages

The group for such development packages is "Development/Libraries".


> %files
> %{_bindir}/*
> %{_libdir}/*

That's a strange place for a static lib.

Also check out:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

Comment 4 Mosaab Alzoubi 2014-02-11 16:41:53 UTC
Thank You :)

- Fix library to be included in -devel.
- Fix -devel group.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-4.fc20.src.rpm

Comment 5 Michael Schwendt 2014-02-11 17:12:51 UTC
And it would still be a static lib:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

But let's focus on OTcl first.

Comment 6 Michael Schwendt 2014-02-12 18:49:13 UTC
Lots of hardcoded …/lib paths in tclcl-1.20/conf/configure.in.otcl, so no surprise it doesn't build on x86_64.

Comment 7 Mosaab Alzoubi 2014-10-03 13:36:36 UTC
- Fix -devel requires.
- Use shared lib instead of static.
- Improving lib locations.

Spec: http://ojuba.org/test/tclcl.spec
Srpm: http://ojuba.org/test/tclcl-1.20-5.oj35.src.rpm

Comment 8 Mosaab Alzoubi 2014-10-05 00:20:05 UTC
- Tweaks:


Spec: http://ojuba.org/test/tclcl.spec
Srpm: http://ojuba.org/test/tclcl-1.20-6.oj35.src.rpm

Comment 9 Zbigniew Jędrzejewski-Szmek 2015-04-06 17:58:54 UTC
Build fails in rawhide, see attached log.

It seems that some private fields in tcl data structures are accessed. Is it possible that something changed in tcl recently?

Comment 10 Zbigniew Jędrzejewski-Szmek 2015-04-06 17:59:36 UTC
Created attachment 1011505 [details]
failing build log on rawhide/i386

Comment 11 Package Review 2020-07-10 00:49:00 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 12 Package Review 2020-08-10 00:48:15 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.