Description of problem: $ cat /export/home/orion/.cache/fedora-review.log 01-06 13:43 root DEBUG fedora-review 0.5.1 bb9bf27 2013-12-13 12:40:49 +0100 started 01-06 13:43 root DEBUG Command line: /usr/bin/fedora-review -b 1048621 01-06 13:43 root INFO Processing bugzilla bug: 1048621 01-06 13:43 root INFO Getting .spec and .srpm Urls from : 1048621 01-06 13:43 root DEBUG Active settings after processing options 01-06 13:43 root DEBUG resultdir: None 01-06 13:43 root DEBUG verbose: False 01-06 13:43 root DEBUG no_report: False 01-06 13:43 root DEBUG session_log: /export/home/orion/.cache/fedora-review.log 01-06 13:43 root DEBUG list_flags: False 01-06 13:43 root DEBUG list_checks: False 01-06 13:43 root DEBUG single: None 01-06 13:43 root DEBUG rpm_spec: False 01-06 13:43 root DEBUG plugins: {} 01-06 13:43 root DEBUG exclude: None 01-06 13:43 root DEBUG configdir: None 01-06 13:43 root DEBUG log_level: 20 01-06 13:43 root DEBUG init_done: True 01-06 13:43 root DEBUG cache: False 01-06 13:43 root DEBUG mock_config: None 01-06 13:43 root DEBUG version: False 01-06 13:43 root DEBUG uniqueext: None 01-06 13:43 root DEBUG flags: [] 01-06 13:43 root DEBUG bz_url: https://bugzilla.redhat.com 01-06 13:43 root DEBUG mock_options: --no-cleanup-after --no-clean 01-06 13:43 root DEBUG list_plugins: False 01-06 13:43 root DEBUG _log_config_done: True 01-06 13:43 root DEBUG other_bz: None 01-06 13:43 root DEBUG plugins_arg: None 01-06 13:43 root DEBUG repo: None 01-06 13:43 root DEBUG use_colors: True 01-06 13:43 root DEBUG bug: 1048621 01-06 13:43 root DEBUG prebuilt: False 01-06 13:43 root DEBUG name: None 01-06 13:43 root DEBUG url: None 01-06 13:43 root DEBUG checksum: sha256 01-06 13:43 root DEBUG nobuild: False 01-06 13:43 root DEBUG _con_handler: <logging.StreamHandler object at 0x2b12150> 01-06 13:43 root INFO --> SRPM url: http://www.geofrogger.net/review/zabbix22-2.2.1-1.1.fc18.src.rpm 01-06 13:43 root INFO --> Spec url: http://www.geofrogger.net/review/zabbix22.spec 01-06 13:43 root DEBUG find_urls completed: 5.892 01-06 13:43 root INFO Using review directory: /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22 01-06 13:43 root DEBUG Avoiding init of working mock root 01-06 13:43 root INFO Downloading .spec and .srpm files 01-06 13:43 root DEBUG Url download completed: 7.035 01-06 13:43 root INFO Using local file zabbix-server-mysql.service as Source14 01-06 13:43 root INFO Using local file zabbix-server-pgsql.service as Source15 01-06 13:43 root INFO Using local file zabbix-fedora-epel.README as Source16 01-06 13:43 root INFO Using local file zabbix-tmpfiles-zabbixsrv.conf as Source17 01-06 13:43 root INFO Using local file zabbix-agentd.service as Source10 01-06 13:43 root INFO Using local file zabbix-proxy-mysql.service as Source11 01-06 13:43 root INFO Using local file zabbix-proxy-pgsql.service as Source12 01-06 13:43 root INFO Using local file zabbix-proxy-sqlite3.service as Source13 01-06 13:43 root INFO Using local file zabbix-server.init as Source2 01-06 13:43 root INFO Using local file zabbix-agentd.init as Source3 01-06 13:43 root INFO Using local file zabbix-2.2.1-free.tar.gz as Source0 01-06 13:43 root INFO Using local file zabbix-web.conf as Source1 01-06 13:43 root INFO Using local file zabbix-proxy.init as Source4 01-06 13:43 root INFO Using local file zabbix-logrotate.in as Source5 01-06 13:43 root INFO Using local file zabbix-tmpfiles-zabbix.conf as Source9 01-06 13:43 root INFO Running checks and generating report 01-06 13:43 root DEBUG Running check: CheckResultdir 01-06 13:43 root DEBUG CheckResultdir completed: 0.001 seconds 01-06 13:43 root DEBUG Running check: CheckBuild 01-06 13:43 root DEBUG Avoiding init of working mock root 01-06 13:43 root DEBUG Build command: mock --no-cleanup-after --no-clean --resultdir=/export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results --rebuild /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/srpm/zabbix22-2.2.1-1.1.fc18.src.rpm 2>&1 | tee build.log | egrep "Results and/or logs|ERROR" 01-06 13:45 root DEBUG _topdir: /builddir/build 01-06 13:45 root INFO WARNING: Probably non-rawhide buildroot used. Rawhide should be used for most package reviews 01-06 13:45 root INFO Build completed 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-server-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-server-mysql-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-server-pgsql-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-agent-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-proxy-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-proxy-mysql-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-proxy-pgsql-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-proxy-sqlite3-2.2.1-1.1.fc20.x86_64.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-web-2.2.1-1.1.fc20.noarch.rpm 01-06 13:45 root DEBUG Running: rpm -ql --dump -p /export/home/orion/redhat/zabbix22-2.2.1/1048621-zabbix22/results/zabbix22-web-mysql-2.2.1-1.1.fc20.noarch.rpm 01-06 13:45 root DEBUG Exception down the road... Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run self._do_run(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 222, in _do_run self._do_report(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 115, in _run_checks writedown=not Settings.no_report) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 377, in run_checks run_check(name) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 351, in run_check check.run() File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_build.py", line 194, in run listfiles() File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_build.py", line 170, in listfiles dirs, files = deps.listpaths(path) File "/usr/lib/python2.7/site-packages/FedoraReview/deps.py", line 183, in listpaths path, mode = line.rsplit(None, 10)[0:5:4] ValueError: need more than 1 value to unpack 01-06 13:45 root ERROR Exception down the road...(logs in /export/home/orion/.cache/fedora-review.log) 01-06 13:45 root DEBUG Report completed: 124.554 seconds Version-Release number of selected component (if applicable): fedora-review-0.5.1-2.fc20.noarch (0.5.1-1 plus patch to fix bug 1044580) fedora-review-0.5.0-3.fc20.noarch How reproducible: Every time Steps to Reproduce: 1. fedora-review -b 1048621
Thanks for reporting this cornercase, caused by malformed rpm output when trying to dump the contents of an empty package. I have pushed a fix[1] to the devel and release-0.5.1 branches which seems to fix this. [1] https://fedorahosted.org/FedoraReview/changeset/1e2d8a7f0fb0cd576d11974917b45eb54dd6ef22
Um, that seems to have fixed it in list_dirs() but not in listpaths() which is where I'm seeing the exception. Applying the same fix there fixes it. Thanks.
Hm,,, seems that I have problems reproducing this, got another one instead. To avoid silly things: could you possibly provide your patch?
Created attachment 846874 [details] my patch Here you go.
Thanks! New upstream patch: https://fedorahosted.org/FedoraReview/changeset/1921b3040555ab15269c9e7f5b
fedora-review-0.5.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.fc20
fedora-review-0.5.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.fc19
fedora-review-0.5.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.el6
Package fedora-review-0.5.1-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing fedora-review-0.5.1-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-0153/fedora-review-0.5.1-2.el6 then log in and leave karma (feedback).
fedora-review-0.5.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.