Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1049688

Summary:	Quickstack manifest parameter renaming
Product:	Red Hat OpenStack	Reporter:	Crag Wolfe <cwolfe>
Component:	openstack-foreman-installer	Assignee:	Crag Wolfe <cwolfe>
Status:	CLOSED ERRATA	QA Contact:	Omri Hochman <ohochman>
Severity:	high	Docs Contact:	Summer Long <slong>
Priority:	unspecified
Version:	4.0	CC:	ajeain, breeler, cwolfe, morazi, oblaut, rhos-maint, yeylon
Target Milestone:	z1	Keywords:	ZStream
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-foreman-installer-1.0.2-1.el6ost	Doc Type:	Bug Fix
Doc Text:	* Some Quickstack manifest parameters have been renamed, as follows: controller_priv_floating_ip is now controller_priv_host controller_pub_floating_ip is now controller_pub_host (above two parameters common throughout manifests) cinder_gluster_peers is now cinder_gluster_servers (in controller manifests) private_interface is now ovs_tunnel_iface (in neutron compute and networker manifests) private_interface is now nova_network_private_iface (in nova network compute manifest) private_interface is now cinder_iscsi_iface (in cinder backend manifest) public_interface is now nova_network_public_iface (in nova network compute manifest) * Some manifest parameters have been removed: bridge_interface (was only referenced in the cisco plugin, but not actually used) public_interface (was declared but not used in neutron compute and networker manifests) * Some foreman_server.sh variables have been removed: PRIVATE_CONTROLLER_IP, PRIVATE_INTERFACE, PRIVATE_NETMASK, PUBLIC_CONTROLLER_IP, PUBLIC_INTERFACE, PUBLIC_NETMASK. The value of PRIVATE_CONTROLLER_IP from foreman_server.sh was used to pre-populate fields in the Foreman Host Group parameters UI. Now, the user needs to make sure that the following parameters have the same IP address, for the typical standalone controller case via the Foreman UI: controller_priv_host mysql_host qpid_host The above three parameters are present in these Host Groups: Controller (Neutron), Controller (Nova Network), Compute (Neutron), Compute (Nova Network), Neutron Networker, LVM Block Storage. The values must be consistent across the Host Groups that users is using for their OpenStack configuration. Likewise, the PUBLIC_CONTROLLER_IP from foreman_server.sh was also used to pre-populate one parameter. Now the user needs to make sure the following parameter is correct from within the Foreman Host Groups UI: controller_pub_host and must be consistent across the subset of the Host Groups relevant to the user: Controller (Neutron), Controller (Nova Network), Compute (Neutron), and Compute (Nova Network). After installing Foreman, the default value for controller_priv_host, mysql_host and qpid_host is 172.16.0.1. For controller_pub_host, the default value is 172.16.1.1. These need to be updated to suit the user's environment, but the defaults are consistent.	Story Points:	---
Clone Of:
Clones:	1053899 (view as bug list)		Environment:
Last Closed:	2014-01-23 14:22:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1053899

Description Crag Wolfe 2014-01-08 02:30:27 UTC

Description of problem:

A number of parameters in Foreman Host Groups are either too vague or inconsistent with similar packstack variables.  For example, $private_interface and $public_interface are used differently across a few different manifests and could be broken into a few distinct parameters.  Other parameters ripe for change include bridge_interface (should be indicated as cisco dependent) and controller_priv_floating_ip (remove "floating").

Additionally, the PUBLIC_/PRIVATE_ env vars in foreman_server.sh may removed and configuration pushed only to the foreman UI.

Version-Release number of selected component (if applicable):
openstack-foreman-installer-1.0.1-1.el6ost.noarch or earlier.

Comment 3 Mike Orazi 2014-01-09 19:42:00 UTC

Can we document the intended changes in this bugzilla so it is easy to verify what has changed?

Comment 4 Crag Wolfe 2014-01-09 20:14:24 UTC

Manifest parameters renamed:

controller_priv_floating_ip -> controller_priv_ip
controller_pub_floating_ip -> controller_pub_ip
 (above two params common throughout manifests)
cinder_gluster_peers -> cinder_gluster_servers
 (in controller manifests)
private_interface -> ovs_tunnel_iface
 (in neutron compute and networker manifests)
private_interface -> nova_network_private_iface
 (in nova network compute manifest)
private_interface -> cinder_iscsi_iface
 (in cinder backend manifest)
public_interface -> nova_network_public_iface
 (in nova network compute manifest)

Manifest parameters removed:
bridge_interface
  (was only referenced in the cisco plugin, but not actually used)
public_interface
  (was declared but not used in neutron compute and networker manifests)

foreman_server.sh variables removed:
PRIVATE_CONTROLLER_IP, PRIVATE_INTERFACE, PRIVATE_NETMASK, PUBLIC_CONTROLLER_IP, PUBLIC_INTERFACE, PUBLIC_NETMASK.

See also:
https://github.com/redhat-openstack/astapor/pull/97/files

Comment 5 Jason Guiditta 2014-01-10 14:45:36 UTC

*** Bug 1047127 has been marked as a duplicate of this bug. ***

Comment 6 Ami Jeain 2014-01-12 15:53:41 UTC

Crag,
plz specify the fixed in version value.

Comment 11 Omri Hochman 2014-01-15 10:00:50 UTC

Verified with :openstack-foreman-installer-1.0.2-1.el6ost.noarch (puddle 2014-01-13.5)

there's no need to edit the values in foreman_server.sh before running the script,
the values under foreman_server.sh are not longer in use.  :

PRIVATE_CONTROLLER_IP= 
PRIVATE_INTERFACE
PRIVATE_NETMASK=
PUBLIC_CONTROLLER_IP=
PUBLIC_INTERFACE=
PUBLIC_NETMASK=


The default values in foreman-server-ui --> host group parameters are: 

mysql_host = 172.16.0.1
qpid_host = 172.16.0.1
controller_priv_ip = 172.16.0.1
controller_pub_ip = 172.16.0.1


Those values should be changed before: running 'puppet agent -t -v' on the foreman_clients.

Comment 13 Summer Long 2014-01-15 23:12:36 UTC

Raised: https://bugzilla.redhat.com/show_bug.cgi?id=1053899
for guide impact.

Comment 14 Bruce Reeler 2014-01-21 06:52:12 UTC

In Doc Text, renamed controller_pub_ip  to controller_pub_host, and 
controler_priv_ip to controler_priv_host, and removed Crag Wolfe's note [1],

because BZ1053729, where this renaming was done, has been VERIFIED.

[1] Crag Wolfe's original note in this bug's Doc Text:
 "NOTE: controller_pub_ip and controler_priv_ip may be renamed to controller_pub_host and controler_priv_host as part of https://bugzilla.redhat.com/show_bug.cgi?id=1053729"

Comment 17 Lon Hohberger 2014-02-04 17:19:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-0046.html