Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1053729

Summary: Foreman controller params should end with _host instead of _ip
Product: Red Hat OpenStack Reporter: Crag Wolfe <cwolfe>
Component: openstack-foreman-installerAssignee: Crag Wolfe <cwolfe>
Status: CLOSED ERRATA QA Contact: Omri Hochman <ohochman>
Severity: high Docs Contact:
Priority: high    
Version: 4.0CC: breeler, cwolfe, jguiditt, mlopes, morazi, rhos-maint, yeylon
Target Milestone: z1Keywords: ZStream
Target Release: 4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-foreman-installer-1.0.3-1.el6ost Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1053897 (view as bug list) Environment:
Last Closed: 2014-01-23 14:23:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1053897    

Description Crag Wolfe 2014-01-15 17:03:13 UTC
Description of problem:

Rename controller_pub_ip and controller_priv_ip Foreman Host Group parameters  to more agnostic controller_pub_host or controller_priv_host-- more agnostic because the user may enter a hostname or an IP address for those values.

Version-Release number of selected component (if applicable):
openstack-foreman-installer-1.0.2-1.el6ost.noarch

Comment 2 Jason Guiditta 2014-01-15 17:55:33 UTC
https://github.com/redhat-openstack/astapor/pull/102

This is merged to master, awaiting flags/acks to cherry pick to stable.

Comment 6 Jason Guiditta 2014-01-16 14:31:54 UTC
This has been tested by development against existing hostrgroups on a fresh install.  The expected outcome is that host groups continue to work as before, and pub/priv_ip params now end with _host instead.  No Functional changes should be expected, and default ip address should be populated in all host groups as before, just attached to a new param name.

Comment 8 Omri Hochman 2014-01-19 13:58:22 UTC
Verified with : openstack-foreman-installer-1.0.3-1.el6ost.noarch (puddle :2014-01-16.1) 

The host groups parameters looks like this now :
--------------------------------------------
controller_priv_host
controller_pub_host
mysql_host
qpid_host

Comment 9 Bruce Reeler 2014-01-21 07:01:33 UTC
Needinfo: Crag Wolfe:

I think the Doc Text for this renaming has already been taken care of in the Doc Text for https://bugzilla.redhat.com/show_bug.cgi?id=1049688 , (which I edited to replace controller_priv_ip with controller_priv_host, and controller_pub_ip with controller_pub_host)

So this bug probably needs to have requires_doc_text set to "-". Confirm?

Comment 10 Mike Orazi 2014-01-21 15:13:10 UTC
Setting to doc_text- as this was confirmed to be correct in the docs for:  https://bugzilla.redhat.com/show_bug.cgi?id=1049688

Comment 13 Lon Hohberger 2014-02-04 17:20:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-0046.html