Spec URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/1/nar-maven-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/1/nar-maven-plugin-3.0.0-1.fc20.src.rpm Fedora Account System Username: goldmann Description: The NAR plugin for Maven allows you to compile native code (C++, C and Fortran) on a number of different architectures (Linux, Windows, MacOSX, Solaris, ...) and with a number of different compilers/linkers (g++, Microsoft Visual C++, CC, ...) The output produced is wrapped up in Native ARchive files (.nar) some of which are machine independent (-noarch), while others are machine specific and thus depend on a combination of machine architecture(A), operating-system(O) and linker(L) identified as AOL. These nar files can be installed in the local Maven repository and deployed to a standard Maven (web) server, using the standard maven-install-plugin and maven-deploy-plugin. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6373908
please, you should/must remove bundled https://github.com/maven-nar/cpptasks-parallel
please, must remove all prebuilt libraries ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll.manifest ./src/it/it0016-layout/lib/x86_64-MacOSX-g++/shared/libit0016-lib-shared-1.0-SNAPSHOT.dylib ./src/it/it0020-lib-3rdparty/src/nar/resources/aol/x86_64-MacOSX-g++/lib/libit0007-lib-shared-1.0-SNAPSHOT.dylib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.exp ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.exp ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/ppc-MacOSX-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/i386-Linux-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86_64-MacOSX-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Linux-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/ppc-MacOSX-gpp/lib/libit0003-jni-1.0-SNAPSHOT.jnilib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86_64-MacOSX-gpp/lib/libit0003-jni-1.0-SNAPSHOT.jnilib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.lib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.lib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/i386-Linux-gpp/lib/libit0003-jni-1.0-SNAPSHOT.so ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Linux-gpp/lib/libit0003-jni-1.0-SNAPSHOT.so
Build fails on arm builder Running com.github.maven_nar.test.TestLinkerVersion Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.216 sec <<< FAILURE! - in com.github.maven_nar.test.TestLinkerVersion testVersion(com.github.maven_nar.test.TestLinkerVersion) Time elapsed: 0.096 sec <<< ERROR! org.apache.maven.plugin.MojoExecutionException: NAR: One of two things may be wrong here: 1. <Name> tag is missing inside the <Linker> tag of your NAR configuration 2. no linker is defined in the aol.properties file for 'arm.Linux.linker' at com.github.maven_nar.Linker.getName(Linker.java:190) at com.github.maven_nar.test.TestLinkerVersion.setUp(TestLinkerVersion.java:49)
http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/build.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/mock_output.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/root.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/state.log
These files should be consider under lgpl license ...(?) from http://java.freehep.org/freehep-nar-plugin/license.html ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteCCompiler.java ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteF77Compiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32Compiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64CLinker.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32CLinker.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinuxFortranCompiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64Compiler.java
(In reply to gil cattaneo from comment #5) > These files should be consider under lgpl license ...(?) > from http://java.freehep.org/freehep-nar-plugin/license.html > http://java.freehep.org/freehep-nar-plugin/cpptasks.html > ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteCCompiler.java > ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteF77Compiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32Compiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64CLinker.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32CLinker.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/ > IntelLinuxFortranCompiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64Compiler.java
Spec URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/2/nar-maven-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/2/nar-maven-plugin-3.0.0-2.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6383506 Changes: - Added support for ARM - Fixed license field - Removed bundled libraries
(In reply to gil cattaneo from comment #1) > please, you should/must remove bundled > https://github.com/maven-nar/cpptasks-parallel This project is obsolete and was merged into the nar-maven-plugin codebase, see README.md, no need to "unbundle".
Sorry, i cant review this package cause: problem/s with mock on my system see https://bugzilla.redhat.com/show_bug.cgi?id=1051485#c1
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 60 files have unknown license. Detailed output of licensecheck in /home/gil/1049942-nar-maven- plugin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [!]: Dist tag is present (not strictly required in GL). [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nar-maven- plugin-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nar-maven-plugin-3.0.0-2.fc21.noarch.rpm nar-maven-plugin-javadoc-3.0.0-2.fc21.noarch.rpm nar-maven-plugin-3.0.0-2.fc21.src.rpm nar-maven-plugin.noarch: W: spelling-error %description -l en_US linkers -> linker, liners, clinkers nar-maven-plugin.noarch: W: spelling-error %description -l en_US noarch -> no arch, no-arch, monarch nar-maven-plugin-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados nar-maven-plugin.src: W: spelling-error %description -l en_US linkers -> linker, liners, clinkers nar-maven-plugin.src: W: spelling-error %description -l en_US noarch -> no arch, no-arch, monarch 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nar-maven-plugin-javadoc nar-maven-plugin nar-maven-plugin-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados nar-maven-plugin.noarch: W: spelling-error %description -l en_US linkers -> linker, liners, clinkers nar-maven-plugin.noarch: W: spelling-error %description -l en_US noarch -> no arch, no-arch, monarch 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nar-maven-plugin-javadoc (rpmlib, GLIBC filtered): jpackage-utils nar-maven-plugin (rpmlib, GLIBC filtered): java jpackage-utils mvn(commons-io:commons-io) mvn(org.apache.ant:ant) mvn(org.apache.bcel:bcel) mvn(org.apache.maven.shared:maven-artifact-resolver) mvn(org.apache.maven.surefire:surefire-booter) mvn(org.apache.maven:maven-artifact) mvn(org.apache.maven:maven-core) mvn(org.apache.maven:maven-model) mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.apache.maven:maven-toolchain) mvn(org.codehaus.plexus:plexus-archiver) mvn(org.codehaus.plexus:plexus-compiler-api) mvn(org.codehaus.plexus:plexus-container-default) mvn(org.codehaus.plexus:plexus-utils) mvn(xerces:xercesImpl) Provides -------- nar-maven-plugin-javadoc: nar-maven-plugin-javadoc nar-maven-plugin: mvn(com.github.maven-nar:nar-maven-plugin) nar-maven-plugin Source checksums ---------------- https://github.com/maven-nar/nar-maven-plugin/archive/nar-maven-plugin-3.0.0.tar.gz : CHECKSUM(SHA256) this package : 656e77ee7f7d4007a119d2104ee89296708084d1b178af66e30715e732e80a20 CHECKSUM(SHA256) upstream package : 656e77ee7f7d4007a119d2104ee89296708084d1b178af66e30715e732e80a20 http://www.apache.org/licenses/LICENSE-2.0.txt : CHECKSUM(SHA256) this package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1049942 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG approved
Thanks! New Package SCM Request ======================= Package Name: nar-maven-plugin Short Description: Native ARchive plugin for Maven Owners: goldmann Branches: f20
Git done (by process-git-requests).
nar-maven-plugin-3.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nar-maven-plugin-3.0.0-2.fc20
nar-maven-plugin-3.0.0-2.fc20 has been pushed to the Fedora 20 stable repository.