Bug 1052151 - Bookmarks do not work when the selected tree-node in the System tree is not "System"
Summary: Bookmarks do not work when the selected tree-node in the System tree is not "...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.4.0
Assignee: Eli Mesika
QA Contact: Jiri Belka
URL:
Whiteboard: ux
: 1059646 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-13 12:12 UTC by Petr Spacek
Modified: 2019-04-28 09:51 UTC (History)
10 users (show)

Fixed In Version: org.ovirt.engine-root-3.4.0-14
Doc Type: Bug Fix
Doc Text:
Previously, bookmarks would not function if a node other than 'System' was selected in the tree pane. Now, the logic used when selecting the Bookmarks tab in the tree pane has been revised so that the 'System' node is selected automatically when the Bookmarks tab is opened, ensuring all bookmarked searches function correctly.
Clone Of:
Environment:
Last Closed: 2014-06-09 15:08:46 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screencast from webadmin (1.04 MB, video/ogg)
2014-01-13 12:12 UTC, Petr Spacek
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2014:0506 0 normal SHIPPED_LIVE Moderate: Red Hat Enterprise Virtualization Manager 3.4.0 update 2014-06-09 18:55:38 UTC
oVirt gerrit 25961 0 None None None Never

Description Petr Spacek 2014-01-13 12:12:06 UTC
Created attachment 849284 [details]
screencast from webadmin

Description of problem:
Bookmarks do not work when Search expression in web admin is not empty.
Please see attached video: I have a bookmark with name "pspacek" and definition "Vms:pspacek".

It does work if I click to "System" node in the tree and then I click to bookmark.

It does not work if I click to "VMs" node in tree and then I click to bookmark. In that case the list of VMs shows the correct result for fraction of second and returns back to complete list of VMs.


Version-Release number of selected component (if applicable):
rhevm-webadmin-portal-3.1.0-50.el6ev.noarch

How reproducible:
100 %

Steps to Reproduce:
0. Define bookmark with name "pspacek" and definition "Vms:pspacek"
1. Click to "VMs" node in tree on the left side
2. Then I click to bookmark

Actual results:
List of VMs blips as you can see on attached video.

Expected results:
It should work as if I click to "System" in the tree.

Comment 2 Einav Cohen 2014-03-24 12:43:46 UTC
*** Bug 1059646 has been marked as a duplicate of this bug. ***

Comment 3 Einav Cohen 2014-03-24 12:46:04 UTC
Eli - please take a look at bug 1059646 and bug 1057141; is your solution in http://gerrit.ovirt.org/25961 in line with the comments within these bugs? what is the GUI behavior after this patch is applied?

Comment 4 Eli Mesika 2014-03-24 21:51:58 UTC
(In reply to Einav Cohen from comment #3)
> Eli - please take a look at bug 1059646 and bug 1057141; is your solution in
> http://gerrit.ovirt.org/25961 in line with the comments within these bugs?

1059646 is completely addressed by my patch

1057141 - This is a completely different issue that is not related to this bug (at least the part that talks about the right menu popup content)

> what is the GUI behavior after this patch is applied?

The behavior after my patch is that the system root in the tree is selected each time you switch to Bookmarks or Tags display. I am not addressing here the saving of the selected node in the system tree and restoring it when switching back from Bookmarks or Tags display to the system tree display but I will be happy to get some instructions of how to do that and add this to my patch.

As I said, I think that the option to Edit/Remove a bookmark without selecting it is not related to this BZ , you can see BTW the same behavior on tags as well , when you right click a tag , you get the Edit/Remove disabled unless you are selecting the tag.
Looking in the system tree I see the same problem , for example have dc1 and dc2 under Data Centers node, both collapsed , now select dc1 and after that right-click + "Expand All" from popup on the Data Centers node, this will expand only dc1 when dc2 stays collapsed , so here we see also that right-click does not select the note 
Having saying that I hope that I had convinced you that this is a totally separate issue that is not related to the one I had addressed here

Comment 6 Einav Cohen 2014-03-31 13:16:20 UTC
Hi Eli, the solution is acceptable, you may proceed with the patch as is, from my perspective. thank you for confirming that with me.

Comment 7 Jiri Belka 2014-04-28 10:06:35 UTC
ok, av7. Entering 'Bookmarks' switches you to top element of the 'System' and makes bookmarks work.

Comment 8 errata-xmlrpc 2014-06-09 15:08:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2014-0506.html


Note You need to log in before you can comment on or make changes to this bug.