Bug 1056045 - virt-v2v OVA import fails when no (optional) manifest file is included
Summary: virt-v2v OVA import fails when no (optional) manifest file is included
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-21 13:15 UTC by Ronald van Zantvoort
Modified: 2015-08-27 14:33 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-04-15 15:47:19 UTC
Embargoed:


Attachments (Terms of Use)
(proposed) patch, although it's not a 100% nice one (499 bytes, patch)
2014-01-21 15:49 UTC, Ronald van Zantvoort
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1056126 0 unspecified CLOSED virt-v2v OVA/OVF import fails with 'MegaBytes' as memory allocation units 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056534 0 unspecified CLOSED virt-v2v OVF/OVA import fails when disks aren't attached to either IDE or SCSI controllers 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056640 0 unspecified CLOSED virt-v2v OVA/OVF import fails when no (optional) ovf:capacityAllocationUnits is specified 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056983 0 unspecified CLOSED virt-v2v OVA/OVF import fails when no (optional) ovf:populatedSize is specified 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1057006 0 unspecified CLOSED virt-v2v OVA/OVF import fails when no (optional) Name under VirtualSystem is specified 2021-02-22 00:41:40 UTC


Description Ronald van Zantvoort 2014-01-21 13:15:32 UTC
Description of problem:
Some virtualization stacks export as OVA without including a .mf manifest file.
DTMF's official OVF spec (http://www.dmtf.org/standards/ovf) under 5.1 states that "An OVF package shall consist of the following (...) zero or one OVF manifest with extension .mf"

However, if no such manifest exists, virt-v2v will collapse with 
"Use of uninitialized value $mf_path in open at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Connection/VMwareOVASource.pm line 254."

Version-Release number of selected component (if applicable):
0.9.0 (latest from Fedora 20 repo)

How reproducible:
Attempt an import of an OVA without a .mf file in it

Actual results:
Use of uninitialized value $mf_path in open at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Connection/VMwareOVASource.pm line 254.
virt-v2v: Failed to open {path}: No such file or directory

Expected results:
Pass over manifest verification and proceed with the import

Comment 1 Ronald van Zantvoort 2014-01-21 15:49:04 UTC
Created attachment 853325 [details]
(proposed) patch, although it's not a 100% nice one

Simple check; if $mf_path remains empty, just return.

Comment 2 Richard W.M. Jones 2015-04-15 15:47:19 UTC
Hi, thanks for the bug report.  Unfortunately it is filed against a
very old version of virt-v2v (0.9) which we don't support at all.

Luckily there is a newer version which almost certainly fixes your
bug already.  It's available starting in Fedora 21.  If you still
experience this bug, please try with the new version, and reopen
if it still happens.

Comment 3 Ronald van Zantvoort 2015-08-27 14:33:21 UTC
(In reply to Richard W.M. Jones from comment #1)
> Unfortunately it is filed against a
> very old version of virt-v2v (0.9) 

Well, that tends to happen if you wait 16 months with a reply to a ready2commit submitted patch.


Note You need to log in before you can comment on or make changes to this bug.