Bug 1057006 - virt-v2v OVA/OVF import fails when no (optional) Name under VirtualSystem is specified
Summary: virt-v2v OVA/OVF import fails when no (optional) Name under VirtualSystem is ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-23 10:27 UTC by Ronald van Zantvoort
Modified: 2015-08-27 14:32 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-15 15:48:23 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1056045 0 unspecified CLOSED virt-v2v OVA import fails when no (optional) manifest file is included 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056126 0 unspecified CLOSED virt-v2v OVA/OVF import fails with 'MegaBytes' as memory allocation units 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056534 0 unspecified CLOSED virt-v2v OVF/OVA import fails when disks aren't attached to either IDE or SCSI controllers 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056640 0 unspecified CLOSED virt-v2v OVA/OVF import fails when no (optional) ovf:capacityAllocationUnits is specified 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1056983 0 unspecified CLOSED virt-v2v OVA/OVF import fails when no (optional) ovf:populatedSize is specified 2021-02-22 00:41:40 UTC


Description Ronald van Zantvoort 2014-01-23 10:27:08 UTC
Description of problem:
When an OVF doesn't specify a Name under the VirtualSystem section, import will fail:
Use of uninitialized value in subroutine entry at /usr/lib64/perl5/vendor_perl/Sys/Virt/Domain.pm line 51.

Version-Release number of selected component (if applicable):
Fedora 20 / virt-v2v 0.9.0

How reproducible:
Import an OVA / OVF without a <Name> element under <VirtualSystem>.

Actual results:
Import fails.

Expected results:
Import succeeds using mandatory ovf:id as name.

Additional info:
OVF (http://www.dmtf.org/sites/default/files/standards/documents/DSP0243_1.0.0.pdf) defines only the ovf:id as mandatory identification attribute. 
If no Name is specified, we should use that to fall back on:

    $meta{name} = _node_val($root, '/Envelope/VirtualSystem/Name/text()') || _node_attr($root,'/Envelope/VirtualSystem','ovf:id') ;

====

sub _node_attr
{
        my ($root, $xpath, $att) = @_;
        my ($node) = $root->findnodes($xpath);
        
        return defined($node) ? $node->getAttribute($att) : undef;
}

Comment 1 Richard W.M. Jones 2015-04-15 15:48:23 UTC
Hi, thanks for the bug report.  Unfortunately it is filed against a
very old version of virt-v2v (0.9) which we don't support at all.

Luckily there is a newer version which almost certainly fixes your
bug already.  It's available starting in Fedora 21.  If you still
experience this bug, please try with the new version, and reopen
if it still happens.

Comment 2 Ronald van Zantvoort 2015-08-27 14:32:49 UTC
(In reply to Richard W.M. Jones from comment #1)
> Unfortunately it is filed against a
> very old version of virt-v2v (0.9) 

Well, that tends to happen if you wait 16 months with a reply to a ready2commit submitted patch.


Note You need to log in before you can comment on or make changes to this bug.