Red Hat Bugzilla – Bug 1061732
Review Request: python-flask-restful - RESTful library for Flask
Last modified: 2015-11-30 18:25:13 EST
Spec URL: http://jsedlak.fedorapeople.org/python-flask-restful.spec
SRPM URL: http://jsedlak.fedorapeople.org/python-flask-restful-0.2.11-1.fc20.src.rpm
Description: Flask-RESTful is Python library for writing RESTful APIs in Flask applications.
It has Python 3 support.
Fedora Account System Username: jsedlak
Here is output from fedora-review package: http://jsedlak.fedorapeople.org/review-python-flask-restful/
It is good habit (but not mandatory) to mark which BR are needed for tests. E.g:
# those are needed for tests:
AUTHORS.md, README.md examples and docs should be put in in doc dir. This should be enough in %files sections:
%doc README.md AUTHORS.md examples docs
you are missing license in package. It should be either
It should be in both packages.
Also the file utils/ordereddict.py is licensed under MIT (according its header) so license should be BSD and MIT. But in upstream this file is no longer present, so you may just rebase.
Ok, I will correct it and repackage to newest version.
(In reply to Jan Sedlák from comment #4)
> Ok, I will correct it and repackage to newest version.
I have updated flask-restful specfile. It uses newest version - 0.3.3.
Since there is a problem with logging into fedorapeople.org, I have uploaded specfile and srpm onto my Dropbox:
There is also problem with fedora-review (namely licensecheck, bug 1240914) so I cannot run fedora-review on my package just yet.
I am using tag tarball (rather than release tarball), because since 0.3, they don't include documentation, tests and LICENSE in release tarball (see https://github.com/flask-restful/flask-restful/issues/475). I had to also delete one testcase with patch - this testcase works only with newer Werkzeug which isn't in repos.
fedora-review is now working (you have to use https://admin.fedoraproject.org/updates/devscripts-2.15.5-6.fc22), so here is its output:
You are packaging .gitignore, which is wrong:
python-flask-restful.noarch: E: version-control-internal-file /usr/share/doc/python-flask-restful/docs/_themes/.gitignore
python3-flask-restful.noarch: E: version-control-internal-file /usr/share/doc/python3-flask-restful/docs/_themes/.gitignore
Otherwise it is good to me.
I have updated it to remove .gitignore before packaging.
Removing FE-NEEDSPONSOR as you were already sponsored by Ralph.
New Package SCM Request
Package Name: python-flask-restful
Short Description: Simple framework for creating REST APIs for Flask
Upstream URL: https://www.github.com/twilio/flask-restful/
Branches: f21 f22 f23 el6 epel7
Git done (by process-git-requests).
python-flask-restful-0.3.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-13802
python-flask-restful-0.3.4-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-13803
python-flask-restful-0.3.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
python-flask-restful-0.3.4-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7311b57ad7
python-flask-restful-0.3.4-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-flask-restful'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7311b57ad7
python-flask-restful-0.3.4-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.