Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1061765

Summary:	Unable to install after previous installation was interrupted
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Tomas Livora <tlivora>
Component:	Installer	Assignee:	Francisco Canas <fcanas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tomas Livora <tlivora>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0.0	CC:	apodhrad, fcanas, kverlaen, mbaluch, rrajasek, rzhang, thauser, tlivora
Target Milestone:	ER3
Target Release:	6.0.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-06 19:53:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Livora 2014-02-05 15:06:03 UTC

Description of problem:
If you interrupt the installation process during the last phase when EAP is running and run the installer again you are not able to successfully complete the installation.

Version-Release number of selected component (if applicable):
6.0.0 CR2

Steps to Reproduce:
1. Run the installer and proceed to the step where EAP is started for a while.
2. Interrupt the installation by clicking on Quit.
3. Try to run the installer again and see the error messages.

Actual results:
Depends on the time when you interrupt the previous installation the new one either says "The port 9999 is already in use, and is required to be open for this installation." or "The required product.conf or layers.conf file at: .../jboss-eap-6.1/bin/product.conf is missing. Please supply either an empty directory or an EAP installation."

Expected results:
When clicking on the quit button the installer should stop the EAP and clean up the target directory.

Comment 1 Marek Baluch 2014-02-10 09:30:49 UTC

IMHO the installer should
- revert the changes for an existing EAP installation
- delete everything in case of a fresh EAP installation

Having said the above I believe nobody will blindly use the installer on an EAP installation which is being used in production. At least not without validating the result on a copy first. That basically means that even if the changes will not be reverted by the installer no damage should occur. It might therefor be sufficient just to document the behaviour for 6.0.1.

Comment 2 Francisco Canas 2014-02-18 16:40:31 UTC

Recent versions of IzPack and Installer-Commons has a Backup and Restore functionality for existing installations.

During the install process:
- Backs up any existing jboss-eap-* folders.
- Keeps a list of all files laid down during the installation.
In the event of installation failure or user cancellation:
- Attempts to shut down any server instances that were started.
- Restores the contents of the backed up jboss-eap-* folder (if any).
- Removes any files that were laid down by the installer.

This should address all of the concerns in the comments above. This functionality is tested and verified in the fsw-installer. The next BPMS/BRMS installer builds will also contain it.

Comment 3 Andrej Podhradsky 2014-03-06 13:41:01 UTC

Verified with 6.0.1.ER2

Comment 4 Tomas Livora 2014-03-27 13:04:15 UTC

The bug is not fixed. If you quit the installation when nothing is in progress the target directory will be cleaned up. However, if you do so during either copying files or running EAP in the last step you will get an error message mentioned in the first post saying: "The required product.conf or layers.conf file at: .../jboss-eap-6.1/bin/product.conf is missing or malformed. Please supply either an empty directory or an EAP installation."

Tested on 6.0.1-CR1

Comment 5 Francisco Canas 2014-03-27 19:25:47 UTC

Hi Tomas,

We've tried reproducing with the BRMS CR1 and CR2 Installers found at these links, and haven't seen the error:
http://dev138.mw.lab.eng.bos.redhat.com/candidate/brms-6.0.1-CR1/
http://dev138.mw.lab.eng.bos.redhat.com/candidate/brms-6.0.1-CR2/

However, the BRMS assembly includes a layers.conf file that shouldn't be included and this will cause issues if user cancels during a layered product installation. I've added a tag to exclude that file from installed packs:

http://git.app.eng.bos.redhat.com/git/brms-installer.git/commit/?id=d0d5c2487d13e54dec422e09a7204c69bcd7e4cd

Note that the bpms assembly does not contain the layers.conf file, so it won't have this potential error with layering.

Comment 6 Tomas Livora 2014-03-31 08:11:26 UTC

The actual error message in the latest version (6.0.1-CR2) is not about layers.conf file but only about product.conf and looks like this:

"The required product.conf file at: .../jboss-eap-6.1/bin/product.conf is missing or malformed. Please supply either an empty directory or an EAP installation."

I tested it on both BRMS and BPMS installers. It can be easily reproduced. Just proceed to the third screen from the end where there is written "Component installation progress" and press the Quit button before it finish copying files. After that when you run the installer again and want to install to the same directory as before the error message mentioned above will appear.

The same behaviour can be seen when you quit the installer on the second screen from the end.

Comment 7 Thomas Hauser 2014-05-20 19:33:07 UTC

This issue has been reproduced and fixed. The behavior is now as described by Marek.

Comment 8 Andrej Podhradsky 2014-06-10 08:08:02 UTC

Verified with BRMS/BPMS Installer 6.0.2.ER3.

But this must be also verified when BZ #1103262 is fixed.

Comment 9 Marek Baluch 2014-06-18 17:57:57 UTC

Marking as VERIFIED.

The main workflow is implemented as described.