Description of problem: gluster volume set network.compression option doesnot verify the valid values. Version-Release number of selected component (if applicable): [root@desktop8 test1]# gluster --version glusterfs 3.5.0beta3 built on Feb 11 2014 20:23:54 Repository revision: git://git.gluster.com/glusterfs.git Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com> GlusterFS comes with ABSOLUTELY NO WARRANTY. You may redistribute copies of GlusterFS under the terms of the GNU General Public License. [root@desktop8 test1]# How reproducible: Steps to Reproduce: 1. Create a replica volume with replica-count=2 2. Use volume set <VOLNAME> network.compression <invalid value> 3. Actual results: The gluster volume set command passed without any error. Expected results: gluster volume set command should have failed. Additional info: [root@desktop8 test1]# gluster volume set gv0 network compression on Usage: volume set <VOLNAME> <KEY> <VALUE> [root@desktop8 test1]# gluster volume set gv0 network.compression on volume set: success [root@desktop8 test1]# gluster volume set gv0 network.compression off volume set: success [root@desktop8 test1]# gluster volume info Volume Name: gv0 Type: Replicate Volume ID: 8d9fb681-6968-455a-8638-7a3a23e1ce5d Status: Started Number of Bricks: 1 x 2 = 2 Transport-type: tcp Bricks: Brick1: 192.168.0.8:/brick1/test1 Brick2: 192.168.0.81:/brick1/test1 Options Reconfigured: network.compression.mode: server network.compression: off [root@desktop8 test1]# gluster volume set gv0 network.compression on volume set: success [root@desktop8 test1]# gluster volume info Volume Name: gv0 Type: Replicate Volume ID: 8d9fb681-6968-455a-8638-7a3a23e1ce5d Status: Started Number of Bricks: 1 x 2 = 2 Transport-type: tcp Bricks: Brick1: 192.168.0.8:/brick1/test1 Brick2: 192.168.0.81:/brick1/test1 Options Reconfigured: network.compression.mode: server network.compression: on [root@desktop8 test1]# gluster volume set gv0 network.compression osdds volume set: success [root@desktop8 test1]# gluster volume info Volume Name: gv0 Type: Replicate Volume ID: 8d9fb681-6968-455a-8638-7a3a23e1ce5d Status: Started Number of Bricks: 1 x 2 = 2 Transport-type: tcp Bricks: Brick1: 192.168.0.8:/brick1/test1 Brick2: 192.168.0.81:/brick1/test1 Options Reconfigured: network.compression.mode: server network.compression: osdds [root@desktop8 test1]#
REVIEW: http://review.gluster.org/7024 (feature/compress: Validate option and enable doc) posted (#1) for review on master by Prashanth Pai (ppai)
REVIEW: http://review.gluster.org/7024 (feature/compress: Validate option and enable doc) posted (#2) for review on master by Prashanth Pai (ppai)
Patch on review: http://review.gluster.org/7024 Fixes BUGs: 1065658, 1065640, 1065655
REVIEW: http://review.gluster.org/7024 (feature/compress: Validate option and enable doc) posted (#3) for review on master by Prashanth Pai (ppai)
COMMIT: http://review.gluster.org/7024 committed in master by Vijay Bellur (vbellur) ------ commit f69e85511645fcbd0526e38ca88dd3e5bf0ed917 Author: Prashanth Pai <ppai> Date: Mon Feb 17 20:42:42 2014 +0530 feature/compress: Validate option and enable doc * Validate network.compression option * Enable descriptions of xlator configurable options * Improve indentation in code * Make network.compression.mode not configurable by user. This is similar to "iam-self-heal-daemon" option in AFR xlator. Fixes BUGs: 1065658, 1065640, 1065655 Change-Id: I99d82b574ee0e5c8c2baf5f5d52dbf8d015d330a BUG: 1065640 Signed-off-by: Prashanth Pai <ppai> Reviewed-on: http://review.gluster.org/7024 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
*** Bug 1065655 has been marked as a duplicate of this bug. ***
*** Bug 1065658 has been marked as a duplicate of this bug. ***
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html [2] http://supercolony.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users