Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1065655

Summary:	[cdc] resetting compression on the volume leaves behind compression option on the volume
Product:	[Community] GlusterFS	Reporter:	SATHEESARAN <sasundar>
Component:	core	Assignee:	Prashanth Pai <ppai>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	medium	Docs Contact:	SATHEESARAN <sasundar>
Priority:	unspecified
Version:	3.5.0	CC:	gluster-bugs, josh, ndevos, ppai, sasundar
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Other
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-11 18:56:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description SATHEESARAN 2014-02-15 12:43:51 UTC

Description of problem:
-----------------------
Resetting compression on the volume, leaves behind a compression option on the volume

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
[gluster@desktop78 ~]$ gluster --version
glusterfs 3.5.0beta3 built on Feb 11 2014 20:06:53
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.

How reproducible:
------------------
Always


Steps to Reproduce:
-------------------
1. Set compression on the volume
2. Reset compression on the volume
3. Check for the volume options

Actual results:
---------------
Compression options are left behind on the volume

Expected results:
-----------------
Reset operation should clean all the compression options

Additional info:
----------------

Here are the steps,

1. Set compression on the volume
(i.e) gluster volume set <vol-name> network.compression on

2. Reset compression
(i.e) gluster volume reset <vol-name> network.compression

3. Check the volume info
(i.e) gluster volume info <vol-name>

Console output
--------------

[root@desktop78 ~]# gluster v i
 
Volume Name: distvol
Type: Distribute
Volume ID: e9e82efe-d5eb-4f74-aa71-bdfe9d94fb9f
Status: Started
Number of Bricks: 2
Transport-type: tcp
Bricks:
Brick1: desktop77.example.com:/brick2/dist1
Brick2: desktop78.example.com:/brick2/dist2
Options Reconfigured:
features.quota: on
network.compression.mode: server
network.compression: on

>>>>>> Resetting compression here

[root@desktop78 ~]# gluster volume reset distvol network.compression
volume reset: success: reset volume successful
 
Volume Name: distvol
Type: Distribute
Volume ID: e9e82efe-d5eb-4f74-aa71-bdfe9d94fb9f
Status: Started
Number of Bricks: 2
Transport-type: tcp
Bricks:
Brick1: desktop77.example.com:/brick2/dist1
Brick2: desktop78.example.com:/brick2/dist2
Options Reconfigured:
features.quota: on
network.compression.mode: server

Comment 1 Prashanth Pai 2014-02-18 04:06:29 UTC

Are the "Expected Results" true ? i.e Reset operation should clean all the compression options.

I see similar behavior in other xlators such as write-behind where options must be individually reset.

Comment 2 Prashanth Pai 2014-02-19 10:01:09 UTC

Patch on review: http://review.gluster.org/7024
Fixes BUGs: 1065658, 1065640, 1065655

Comment 3 SATHEESARAN 2014-02-19 10:18:35 UTC

(In reply to Prashanth Pai from comment #1)
> Are the "Expected Results" true ? i.e Reset operation should clean all the
> compression options.
> 
> I see similar behavior in other xlators such as write-behind where options
> must be individually reset.

Prashanth,

It would look good, to remove the options related to xlator, if they are not available in the client /server stack.

These attributes would definitely confuse the admin/user when he checks the gluster volume info.

Thanks for understanding

Comment 4 Niels de Vos 2014-07-11 18:56:25 UTC


*** This bug has been marked as a duplicate of bug 1065640 ***