Spec URL: http://petersen.fedorapeople.org/reviews/ghc-HTTP.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-HTTP-4000.2.8-31.fc20.src.rpm Description: The HTTP package supports client-side web programming in Haskell. It lets you set up HTTP connections, transmitting requests and processing the responses coming back, all from within the comforts of Haskell. It's dependent on the network package to operate, but other than that, the implementation is all written in Haskell. A basic API for issuing single HTTP requests + receiving responses is provided. On top of that, a session-level abstraction is also on offer (the 'BrowserAction' monad); it taking care of handling the management of persistent connections, proxies, state (cookies) and authentication credentials required to handle multi-step interactions with a web server. The representation of the bytes flowing across is extensible via the use of a type class, letting you pick the representation of requests and responses that best fits your use. Some pre-packaged, common instances are provided for you ('ByteString', 'String').
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6542168 This is part of splitting out cabal-install from haskell-platform. Original package review is bug 1066346.
*** Bug 1066363 has been marked as a duplicate of this bug. ***
> Original package review is bug 1066346. Sorry I meant bug 470756.
Package APPROVED. Review to follow: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/ghc-HTTP See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names (This will go away after import) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1884160 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-HTTP-4000.2.8-31.fc20.x86_64.rpm ghc-HTTP-devel-4000.2.8-31.fc20.x86_64.rpm ghc-HTTP-4000.2.8-31.fc20.src.rpm ghc-HTTP.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-HTTP.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti ghc-HTTP.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee ghc-HTTP.src: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-HTTP.src: W: spelling-error %description -l en_US multi -> mulch, mufti ghc-HTTP.src: W: spelling-error %description -l en_US pre -> per, ore, pee 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-HTTP ghc-HTTP-devel ghc-HTTP.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-HTTP.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti ghc-HTTP.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- ghc-HTTP (rpmlib, GLIBC filtered): ghc(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3) ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f) ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b) ghc(old-time-1.1.0.1-2f8ea093d0c7014780a8a5772f948883) ghc(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSmtl-2.1.2-ghc7.6.3.so()(64bit) libHSnetwork-2.4.1.2-ghc7.6.3.so()(64bit) libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit) libHSold-time-1.1.0.1-ghc7.6.3.so()(64bit) libHSparsec-3.1.3-ghc7.6.3.so()(64bit) libHStext-0.11.3.1-ghc7.6.3.so()(64bit) libHStime-1.4.0.1-ghc7.6.3.so()(64bit) libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit) libHSunix-2.6.0.1-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgmp.so.10()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) ghc-HTTP-devel (rpmlib, GLIBC filtered): /bin/sh ghc(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185) ghc-HTTP(x86-64) ghc-compiler ghc-devel(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3) ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc-devel(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f) ghc-devel(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc-devel(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b) ghc-devel(old-time-1.1.0.1-2f8ea093d0c7014780a8a5772f948883) ghc-devel(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4) Provides -------- ghc-HTTP: ghc(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185) ghc-HTTP ghc-HTTP(x86-64) libHSHTTP-4000.2.8-ghc7.6.3.so()(64bit) ghc-HTTP-devel: ghc-HTTP-devel ghc-HTTP-devel(x86-64) ghc-HTTP-static ghc-devel(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185) Unversioned so-files -------------------- ghc-HTTP: /usr/lib64/ghc-7.6.3/HTTP-4000.2.8/libHSHTTP-4000.2.8-ghc7.6.3.so Source checksums ---------------- http://hackage.haskell.org/package/HTTP-4000.2.8/HTTP-4000.2.8.tar.gz : CHECKSUM(SHA256) this package : 086a2aa771a31845b190e2f9651ab4d8e85116aa463de5bc5e0204c1e5e70c5c CHECKSUM(SHA256) upstream package : 086a2aa771a31845b190e2f9651ab4d8e85116aa463de5bc5e0204c1e5e70c5c Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b ghc-http Buildroot used: fedora-20-x86_64 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank you for the review! Package Change Request ====================== Package Name: ghc-HTTP New Branches: f20 f19 epel7 Owners: petersen InitialCC: haskell-sig
Git done (by process-git-requests).
Thanks again Closing this out - built for F21 rawhide. There will be a consolidated backport later to F20 and EPEL7.
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, haskell-platform-2013.2.0.0-33.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-transformers-0.3.0.0-33.fc20,haskell-platform-2013.2.0.0-33.fc20
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.