Spec URL: http://petersen.fedorapeople.org/reviews/cabal-install.spec SRPM URL: http://petersen.fedorapeople.org/reviews/cabal-install-1.16.0.2-31.fc20.src.rpm Description: The 'cabal' command-line program simplifies the process of managing Haskell packages by automating the fetching, configuration, compilation and installation of Haskell libraries and programs from Hackage.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6563761
This review is to split cabal-install out of haskell-platform. See bug 471003 for the original old review.
Hello, is this a re-review for unorphaning the devel branch in Fedora rawhide?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 67 files have unknown license. Detailed output of licensecheck in /home/slaanesh/Documents/fedora/1069062-cabal- install/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/profile.d [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/bash_completion.d(git, rpmdevtools, filesystem, pulseaudio, yum-utils, bash-completion, fedpkg, udisks) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cabal-install-1.16.0.2-31.fc20.x86_64.rpm cabal-install-1.16.0.2-31.fc20.src.rpm cabal-install.x86_64: W: non-conffile-in-etc /etc/profile.d/cabal-install.sh cabal-install.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/cabal cabal-install.x86_64: W: no-manual-page-for-binary cabal 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint cabal-install cabal-install.x86_64: W: non-conffile-in-etc /etc/profile.d/cabal-install.sh cabal-install.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/cabal cabal-install.x86_64: W: no-manual-page-for-binary cabal 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- cabal-install (rpmlib, GLIBC filtered): ghc(Cabal-1.16.0-eb3c12450ebbf2810048acb780cbe706) ghc(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185) ghc(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3) ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f) ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926) ghc(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2) ghc(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe) ghc(ghc-prim-0.3.0.0-d5221a8c8a269b66ab9a07bdc23317dd) ghc(integer-gmp-0.5.0.0-2f15426f5b53fe4c6490832f9b20d8d7) ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b) ghc(old-locale-1.0.0.5-6729cb9d9cc62d150655de8fc5401b91) ghc(old-time-1.1.0.1-2f8ea093d0c7014780a8a5772f948883) ghc(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4) ghc(pretty-1.1.1.0-66181c695e6a2e173ba2088cf55cc396) ghc(process-1.1.0.2-76e05340eb66705981411022731ca84a) ghc(random-1.0.1.1-43fdc5da991685d8a0ec8cb553880cf8) ghc(text-0.11.3.1-e38859e86485c167fa7c9441789e7607) ghc(time-1.4.0.1-10dc4804a19dc0000fab79908f1a9f50) ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) ghc(unix-2.6.0.1-4f219f792083f70ec440ce406f12ce57) ghc(zlib-0.5.4.1-13ba81ac0d7e6f3bdf1ee5ddce4e9aab) ghc-compiler libHSCabal-1.16.0-ghc7.6.3.so()(64bit) libHSHTTP-4000.2.8-ghc7.6.3.so()(64bit) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit) libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSdirectory-1.2.0.1-ghc7.6.3.so()(64bit) libHSfilepath-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSmtl-2.1.2-ghc7.6.3.so()(64bit) libHSnetwork-2.4.1.2-ghc7.6.3.so()(64bit) libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit) libHSold-time-1.1.0.1-ghc7.6.3.so()(64bit) libHSparsec-3.1.3-ghc7.6.3.so()(64bit) libHSpretty-1.1.1.0-ghc7.6.3.so()(64bit) libHSprocess-1.1.0.2-ghc7.6.3.so()(64bit) libHSrandom-1.0.1.1-ghc7.6.3.so()(64bit) libHSrts_thr-ghc7.6.3.so()(64bit) libHStext-0.11.3.1-ghc7.6.3.so()(64bit) libHStime-1.4.0.1-ghc7.6.3.so()(64bit) libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit) libHSunix-2.6.0.1-ghc7.6.3.so()(64bit) libHSzlib-0.5.4.1-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- cabal-install: cabal-install cabal-install(x86-64) Source checksums ---------------- http://hackage.haskell.org/package/cabal-install-1.16.0.2/cabal-install-1.16.0.2.tar.gz : CHECKSUM(SHA256) this package : 66dfacc9f33e668e56904072cadb8a36bd9d6522ba5464c6a36a5de7e65c5698 CHECKSUM(SHA256) upstream package : 66dfacc9f33e668e56904072cadb8a36bd9d6522ba5464c6a36a5de7e65c5698 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1069062 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
> [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /etc/bash_completion.d(git, > rpmdevtools, filesystem, pulseaudio, yum-utils, bash-completion, fedpkg, > udisks) > [!]: Requires correct, justified where necessary. The package should not own %{_sysconfdir}/bash_completion.d, as it is owned by the package "filesystem". Also the directory %{_sysconfdir}/profile.d is owned by the setup package. Please change the %files section as follows: %{_sysconfdir}/bash_completion.d/cabal %{_sysconfdir}/profile.d/cabal-install.sh Or: %{_sysconfdir}/bash_completion.d/* %{_sysconfdir}/profile.d/* And add the following Requires at the top: Requires: filesystem Requires: setup > [!]: Latest version is packaged. According to http://hackage.haskell.org/package/cabal-install, the last version is 1.18.0.3. Is there any reason for why it's not packaged? > Rpmlint > ------- > cabal-install.x86_64: W: non-conffile-in-etc /etc/profile.d/cabal-install.sh > cabal-install.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/cabal Please mark the files as %config or better %config(noreplace). If they are not edited by the user; they will be updated anyway if the package gets updated.. %config(noreplace) %{_sysconfdir}/bash_completion.d/cabal %config(noreplace) %{_sysconfdir}/profile.d/cabal-install.sh Apart from these small issues, the package is good to go! Please confirm this is a re-review for unorphaning the package in devel.
(In reply to Simone Caronni from comment #3) > Hello, is this a re-review for unorphaning the devel branch in Fedora > rawhide? Clarification: I read in comment #2 that this is to split from haskell platform, but pkgdb shows that the package was already available and then later deprecated: https://admin.fedoraproject.org/pkgdb/acls/name/cabal-install It was removed due to inclusion in haskell and then it's now being made separate again?
(In reply to Simone Caronni from comment #3) > Hello, is this a re-review for unorphaning the devel branch in Fedora > rawhide? Yes, that's right: cabal-install is currently a subpackage of haskell-platform but I want to move it out into its own source package again. > And add the following Requires at the top: > > Requires: filesystem > Requires: setup Sure > According to http://hackage.haskell.org/package/cabal-install, the last > version is 1.18.0.3. Is there any reason for why it's not packaged? I plan to update rawhide to 1.18 later, current haskell-platform for ghc-7.6.3 specifies cabal-install-1.16.0.2. > %config(noreplace) %{_sysconfdir}/bash_completion.d/cabal > %config(noreplace) %{_sysconfdir}/profile.d/cabal-install.sh Thanks for catching this. Let me update the submission shortly.
(In reply to Simone Caronni from comment #6) > It was removed due to inclusion in haskell[-platform] and > then it's now being made separate again? Yes I am afraid so: I regret moving it to be packaged monolithically in haskell-platform so going forward I would like it to be a separate package again so we are less dependent on haskell-platform for updating it.
Spec: http://petersen.fedorapeople.org/reviews/cabal-install/cabal-install.spec SRPM: http://petersen.fedorapeople.org/reviews/cabal-install/cabal-install-1.16.0.2-32.fc18.src.rpm Added %config(noreplace) and Requires.
Package approved!
Thank you Simone! Package Change Request ====================== Package Name: cabal-install New Branches: f20 f19 Owners: petersen InitialCC: haskell-sig
Git done (by process-git-requests).
Thanks again. It is built for f21 and I will backport soon to f20 and epel7.
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, haskell-platform-2013.2.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2014-4579/alex-3.0.5-36.fc20,cabal-install-1.16.0.2-34.fc20,ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-parallel-3.2.0.3-34.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-compat-0.95.1-34.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-syb-0.4.0-35.fc20,ghc-transformers-0.3.0.0-33.fc20,happy-1.18.10-34.fc20,haskell-platform-2013.2.0.0-33.fc20
Package ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-async-2.0.1.4-30.fc20 ghc-html-1.0.1.2-28.fc20 ghc-HTTP-4000.2.8-32.fc20 ghc-HUnit-1.2.5.2-31.fc20 ghc-network-2.4.1.2-31.fc20 ghc-parsec-3.1.3-30.fc20 ghc-QuickCheck-2.6-32.fc20 ghc-regex-base-0.93.2-28.fc20 ghc-regex-posix-0.95.2-29.fc20 ghc-transformers-0.3.0.0-33.fc20 alex-3.0.5-36.fc20 cabal-install-1.16.0.2-34.fc20 ghc-parallel-3.2.0.3-34.fc20 ghc-regex-compat-0.95.1-34.fc20 ghc-syb-0.4.0-35.fc20 happy-1.18.10-34.fc20 haskell-platform-2013.2.0.0-36.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-4579/alex-3.0.5-36.fc20,cabal-install-1.16.0.2-34.fc20,ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-parallel-3.2.0.3-34.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-compat-0.95.1-34.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-syb-0.4.0-35.fc20,ghc-transformers-0.3.0.0-33.fc20,happy-1.18.10-34.fc20,haskell-platform-2013.2.0.0-36.fc20 then log in and leave karma (feedback).
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.