Bug 1068626 - [RFE] [webadmin] [network labels] add support for renaming Network Label
Summary: [RFE] [webadmin] [network labels] add support for renaming Network Label
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
: ---
Assignee: bugs@ovirt.org
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-21 14:18 UTC by Martin Pavlik
Modified: 2019-04-28 10:03 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-06 07:26:51 UTC
oVirt Team: Network
Embargoed:
ylavi: ovirt-future?
ylavi: planning_ack?
ylavi: devel_ack?
ylavi: testing_ack?


Attachments (Terms of Use)

Description Martin Pavlik 2014-02-21 14:18:54 UTC
Description of problem:
please add support for renaming Network Label on network level

so following would be possible

1) create Labeled, non-required network NET1 with label lb_1
2) label host interfaces eth1 == lb_1 and eth2 == lb_2
3) change label of network NET1 from lb_1 to lb_2


Expected results:
Network NET1 is attached to eth2

Comment 1 Einav Cohen 2014-05-12 18:53:39 UTC
AFAIK, the network labels are not a managed business entity in ovirt, so this may be a bit of a challenge to implement. 

from a UX point of view: in order to implement this properly, we need to display the list of labels somewhere (e.g. either combine it with the existing Network sub-tab in the Data Center main tab / add a new sub tab / ...) and add the functionality of label editing from there (it will obviously be natural to add also "Add", "Remove" actions there as well). 

we should also think about editing labels from the Setup Host Networks dialog (even though the context is a Host, and the change may affect business entities out of this context - this would still be a good UX, since the user won't be forced to leave the current context in order to perform this action).

Comment 2 Lior Vernia 2014-09-02 12:48:50 UTC
See additional information in Bug 1134009 on implementing this with respect to VMs using labelled networks.

Comment 3 Liz 2014-09-10 14:46:27 UTC
A few comments based on Moti's explanation of this feature enhancement in Bug 1134009 ...

1) The user should receive a warning in the UI if there is a network label that is being renamed that will break the connection between the Host and Network. The user can then confirm that they still want to perform this action.

2) If the user can't rename a label (due to Network attached to running VMs) we should disabled this action and give the user a message letting them know why they can't rename the label. Even nicer, giving the user an option to shut down these VMs/unplug the relevant NICs from the VMs/etc..., then rename the label, then restart the VMs/plug in the relevant NICs to the VMs/etc... would be ideal. That way we walk the user through the process of what they'd like to accomplish.

Comment 5 Sandro Bonazzola 2015-09-04 09:02:43 UTC
This is an automated message.
This Bugzilla report has been opened on a version which is not maintained anymore.
Please check if this bug is still relevant in oVirt 3.5.4.
If it's not relevant anymore, please close it (you may use EOL or CURRENT RELEASE resolution)
If it's an RFE please update the version to 4.0 if still relevant.

Comment 6 Michael Burman 2015-09-08 09:19:42 UTC
This bug is still relevant on - 3.6.0-0.13.master.el6
and on 3.5.4.2-1.3.el6ev

Renaming network's label is not supported. 

Operation Canceled:

'Error while executing action: Cannot edit Network. Renaming a network label while configured on hosts interfaces is not supported. Please unlabel the network first and later specify the new one.'

Thanks.

Comment 7 Yaniv Lavi 2018-06-06 07:26:51 UTC
Closing old RFEs, please reopen if still needed.
Patches are always welcomed.


Note You need to log in before you can comment on or make changes to this bug.