Bug 1134009 - [Network label] RHEV does not allow adding label for a network being used by VMs
Summary: [Network label] RHEV does not allow adding label for a network being used by VMs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.5.0
Assignee: Martin Mucha
QA Contact: Michael Burman
URL:
Whiteboard: network
Depends On:
Blocks: 1142203 rhev3.5beta3
TreeView+ depends on / blocked
 
Reported: 2014-08-26 15:43 UTC by akotov
Modified: 2019-04-28 08:37 UTC (History)
14 users (show)

Fixed In Version: org.ovirt.engine-root-3.5.0-13
Doc Type: Bug Fix
Doc Text:
With this update, network labels can now be added to networks that are being used by running virtual machines.
Clone Of:
: 1142203 (view as bug list)
Environment:
Last Closed: 2015-02-11 18:08:45 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0158 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Virtualization Manager 3.5.0 2015-02-11 22:38:50 UTC
oVirt gerrit 32688 0 master MERGED core: allowed to add network label even if Vm using this network is running. Never
oVirt gerrit 32968 0 ovirt-engine-3.5 MERGED core: allowed to add network label even if Vm using this network is running. Never
oVirt gerrit 33846 0 master MERGED core: error fix: removed statement negation Never
oVirt gerrit 33855 0 ovirt-engine-3.5 MERGED core: error fix: removed statement negation Never

Description akotov 2014-08-26 15:43:57 UTC
Version-Release number of selected component (if applicable):

rhevm-backend-3.4.1-0.31.el6ev.noarch

How reproducible:

Always

Steps to Reproduce:
1. Default cluster, 1 VM running, no labels attached to hosts NICs, default rhevm network
2.  Networks => Edit => Network label => type in test => press OK,OK

Actual results:

RHEV does not allow to add/edit label as network is in use by VMs
"Several virtual machines (1) are using this logical network"

Expected results:

RHEV should allow add/edit label with VMs running, as no network configuration is updated on the hosts. Behavior should be similar to editing description/comment for the network.


Additional info:

It should work at least if label is not currently in use by any hosts, not sure about possible implications if label is already used for some hosts.

Comment 1 Nir Yechiel 2014-08-27 12:07:17 UTC
This issue was already raised in the past. Moti, do we have any safe way to allow this?

Thanks,
Nir

Comment 2 akotov 2014-08-27 12:58:58 UTC
I was able to workaround it BTW by hot-unplugging NIC from VM, doing what needs to be done with label, and plugging back NIC again.

Comment 3 Moti Asayag 2014-08-31 07:21:53 UTC
(In reply to Nir Yechiel from comment #1)
> This issue was already raised in the past. Moti, do we have any safe way to
> allow this?
> 
> Thanks,
> Nir

Yes, currently the rename action is not supported.
Renaming a label of a network should behave as:
1. When network isn't used - allow it.
2. When network is provisioned on hosts via label - renaming the label will remove the network from the hosts. (If the user wish to preserve that label on the hosts, the user should label the hosts' interfaces with the new label)
2.1. If the network is being used by running vms, and renaming it will trigger its removal from hosts - it should be blocked.
2.1. The network should be configured on any host that is labeled with the new label, where the network hasn't been configured on that host.

Adding a label is simpler, since this action is currently supported
1. If the network is being used by vms, allow it: It implies the network is already configured on a host and adding a label will only provision it on hosts where that network hasn't been configured.

Comment 4 Lior Vernia 2014-09-02 12:50:44 UTC
Since Bug 1068626 already exists for renaming network labels, I'm limiting this to just the case of adding a new label for networks being used by VMs - should be easier to fix and solve a lot of issues for users/customers with existing deployments who are looking to adopt the feature.

Comment 5 Liz 2014-09-10 14:37:06 UTC
The logic that Moti explains above for adding new labels makes sense. We will add UX comments around editing network labels to Bug 1068626.

Comment 7 Eyal Edri 2014-09-28 11:29:38 UTC
this bug was moved to MODIFIED before vt4 build date thus moving to ON_QA.
if you belive this bug isn't in vt4, please report to rhev-integ

Comment 8 Martin Pavlik 2014-10-02 08:47:04 UTC
with vt4 scenario fails exactly as described in comment 0

Red Hat Enterprise Virtualization Manager Version: 3.5.0-0.13.beta.el6ev 

Error while executing action: Cannot edit Network. Several virtual machines (1) are using this logical network:
VM1
- Please remove it from all virtual machines that are using it and try again.

Comment 9 Lior Vernia 2014-10-02 08:58:37 UTC
Hmmm, interesting that this didn't make the build, will check what's that about.

Comment 11 Michael Burman 2014-10-19 10:50:32 UTC
Verified on - 3.5.0-0.15.beta.el6ev(vt6)


- This bug should only deal with adding a new label for networks being used by VMs, not editing or renaming it.

Comment 13 errata-xmlrpc 2015-02-11 18:08:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0158.html


Note You need to log in before you can comment on or make changes to this bug.