Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1068629

Summary: [webadmin] [network labels] block editing of network label for a network which is already attached to host interface
Product: [Retired] oVirt Reporter: Martin Pavlik <mpavlik>
Component: ovirt-engine-webadminAssignee: bugs <bugs>
Status: CLOSED NOTABUG QA Contact: bugs <bugs>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.4CC: acathrow, ecohen, gklein, iheim, masayag, mgoldboi, myakove, yeylon
Target Milestone: ---Keywords: Triaged, UserExperience
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-23 07:24:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot 1 none

Description Martin Pavlik 2014-02-21 14:34:14 UTC 
Created attachment 866044 [details]
screenshot 1

Description of problem:

at the moment if user edits network label of a network that is already attached to host in such way that it matches another host interface it leads to unwanted state of setup host networks dialog

editing of network label which is already attached to host interface should be blocked, at least until RFE for Network label editing will be implemented (see bug 1068626 )


Version-Release number of selected component (if applicable):
oVirt Engine Version: 3.4.0-0.11.beta3.el6 

How reproducible:
100%

Steps to Reproduce:
1) create Labeled, non-required network NET1 with label lb_1
2) label host interfaces eth1 == lb_1 and eth2 == lb_2
3) change label of network NET1 from lb_1 to lb_2
4) go to Hosts -> your host -> Network Interfaces -> Setup Host Networks (see screenshot)

Actual results:
network label can be edited and it leads to unwanted network configuration

Expected results:
block editing of network label for a network which is already attached to host interface 

Additional info:

real configuration on the host

[root@dell-r210ii-08 ~]# cat /etc/sysconfig/network-scripts/ifcfg-em2
# Generated by VDSM version 4.14.3-0.el6
DEVICE=em2
ONBOOT=yes
HWADDR=d0:67:e5:f0:7f:30
BRIDGE=NET1_bridged
NM_CONTROLLED=no
STP=no
[root@dell-r210ii-08 ~]# cat /etc/sysconfig/network-scripts/ifcfg-NET1_bridged 
# Generated by VDSM version 4.14.3-0.el6
DEVICE=NET1_bridged
ONBOOT=yes
TYPE=Bridge
DELAY=0
NM_CONTROLLED=no
STP=no
[root@dell-r210ii-08 ~]# cat /etc/sysconfig/network-scripts/ifcfg-p1p1
DEVICE=p1p1
HWADDR=90:E2:BA:04:28:B8
TYPE=Ethernet
UUID=f533937b-bcd8-44ab-9508-ab1e306f8970
ONBOOT=no
NM_CONTROLLED=yes
BOOTPROTO=dhcp
Comment 1 Moti Asayag 2014-02-23 07:24:12 UTC 
The third step is not supported:

3) change label of network NET1 from lb_1 to lb_2

This is blocked by a can-do-action and RFE was reported to support it (Bug 1068626). But until this RFE is implemented, the only method of renaming labels is via unlabel the network (which should remove the network from any host it is configured on) and labeling the network with the new label (which will configure the network on all of the labeled interface).

Therefore there shouldn't be unwanted network configuration, unless from some reason the any of the operation failed (i.e. due to non responsiveness of the host during the label action) and for that an event log should notify the admin about that issue.