Bug 1069124 - Review Request: python-netlib - Collection of network utility classes
Summary: Review Request: python-netlib - Collection of network utility classes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: python-mitmproxy
TreeView+ depends on / blocked
 
Reported: 2014-02-24 09:33 UTC by Dhiru Kholia
Modified: 2014-03-13 05:05 UTC (History)
2 users (show)

Fixed In Version: python-netlib-0.10-3.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-27 16:54:52 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Dhiru Kholia 2014-02-24 09:33:02 UTC
Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-netlib/python-netlib.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-netlib/python-netlib-0.10-1.fc20.src.rpm

Description: Netlib is a collection of network utility classes, used by the pathod and mitmproxy projects. It differs from other projects in some fundamental respects, because both pathod and mitmproxy often need to violate standards. This means that protocols are implemented as small, well-contained and flexible functions, and are designed to allow misbehaviour when needed.

https://github.com/mitmproxy/netlib

Fedora Account System Username: halfie

Comment 1 Parag AN(पराग) 2014-02-25 04:54:10 UTC
package failed to build from scratch

Comment 3 Parag AN(पराग) 2014-02-25 14:50:04 UTC
Review:-

+ Package build successfully in rawhide mock

+ Source verified with upstream as (sha256sum)
srpm tarball : 415e3db96f487177f372d47bc669dcc9068a435e49b8120ec8821026de36bd80
upstream tarball : 415e3db96f487177f372d47bc669dcc9068a435e49b8120ec8821026de36bd80

+ rpmlint on generated rpms gave output
python-netlib.noarch: W: spelling-error %description -l en_US pathod -> pathos, pat hod, pat-hod
python-netlib.noarch: W: spelling-error %description -l en_US mitmproxy -> proximity
python-netlib.noarch: W: spelling-error %description -l en_US misbehaviour -> misbehavior, behaviorism
python-netlib.src: W: spelling-error %description -l en_US pathod -> pathos, pat hod, pat-hod
python-netlib.src: W: spelling-error %description -l en_US mitmproxy -> proximity
python-netlib.src: W: spelling-error %description -l en_US misbehaviour -> misbehavior, behaviorism
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ License of this package is MIT which is given in source setup.py.


Suggestions:
1) Group tag is optional so you can remove it if this package is only for Fedora.

2) Package should own %{python2_sitelib}/* files only and not directory %{python2_sitelib}

APPROVED.

Comment 4 Dhiru Kholia 2014-02-26 18:37:41 UTC
New Package SCM Request
=======================
Package Name: python-netlib
Short Description: Collection of network utility classes
Owners: halfie
Branches: f20
InitialCC: panemade

Comment 5 Parag AN(पराग) 2014-02-27 02:55:14 UTC
Dhiru,
  Use paragn as a InitialCC which is valid FAS name.

Comment 6 Dhiru Kholia 2014-02-27 05:16:41 UTC
New Package SCM Request
=======================
Package Name: python-netlib
Short Description: Collection of network utility classes
Owners: halfie
Branches: f20
InitialCC: paragn

Comment 7 Gwyn Ciesla 2014-02-27 13:12:02 UTC
Git done (by process-git-requests).

Comment 8 Dhiru Kholia 2014-02-27 16:54:52 UTC
All set :-)

Comment 9 Fedora Update System 2014-03-08 20:06:00 UTC
python-netlib-0.10-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-netlib-0.10-3.fc20

Comment 10 Fedora Update System 2014-03-13 05:05:51 UTC
python-netlib-0.10-3.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.