Bug 1070418 (python-mitmproxy) - Review Request: python-mitmproxy - An interactive SSL-capable intercepting HTTP proxy
Summary: Review Request: python-mitmproxy - An interactive SSL-capable intercepting HT...
Keywords:
Status: CLOSED DUPLICATE of bug 1198760
Alias: python-mitmproxy
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1069124
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-26 19:03 UTC by Dhiru Kholia
Modified: 2015-03-04 19:04 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-04 19:04:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dhiru Kholia 2014-02-26 19:03:39 UTC
Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy-0.10-1.fc20.src.rpm

Description: mitmproxy is an interactive, SSL-capable man-in-the-middle proxy for HTTP with a console interface.

mitmdump is the command-line version of mitmproxy. Think tcpdump for HTTP.

libmproxy is the library that mitmproxy and mitmdump are built on.

Documentation, tutorials and distribution packages can be found on the
mitmproxy.org website: www.mitmproxy.org.

Fedora Account System Username: halfie

Comment 1 Fabian Affolter 2014-02-26 22:01:14 UTC
- This package has python-netlib as requirement. But python-netlib is not available in the Fedora Package Collection.

 $ yum search python-netlib
 Loaded plugins: langpacks, refresh-packagekit
 Warning: No matches found for: python-netlib
 No matches found

- The %doc line looks unusual.
- I would like it more if http://www.mitmproxy.org is used as URL: 
- Please remove the section "Documentation, tutorials and..." from the %description. It's obvious that often additional information can be found on upstream's web presence.

Comment 2 Dhiru Kholia 2014-02-27 05:36:00 UTC
"python-netlib" will be available soon (BZ #1069124). Sorry for introducing a package review "race" ;)

Updated the package,

Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy-0.10-2.fc20.src.rpm

Thank you for the feedback!

Comment 3 Dhiru Kholia 2014-03-10 10:42:47 UTC
Hi Fabian,

Is there any progress on this bug?

Comment 4 Fabian Affolter 2014-03-12 12:08:56 UTC
There are two errors:

[fab@laptop011 results]$ rpmlint python-mitmproxy-0.10-2.fc20.noarch.rpm
python-mitmproxy.noarch: E: explicit-lib-dependency python-netlib
python-mitmproxy.noarch: W: spelling-error %description -l en_US tcpdump -> Dumpster
python-mitmproxy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libmproxy/contrib/html2text.py 0644L /usr/bin/env
python-mitmproxy.noarch: W: no-manual-page-for-binary mitmproxy
python-mitmproxy.noarch: W: no-manual-page-for-binary mitmdump
1 packages and 0 specfiles checked; 2 errors, 3 warnings.

Comment 5 Dhiru Kholia 2014-03-12 13:18:24 UTC
(In reply to Fabian Affolter from comment #4)
> $ rpmlint python-mitmproxy-0.10-2.fc20.noarch.rpm
> python-mitmproxy.noarch: E: explicit-lib-dependency python-netlib

This one seems like a false positive to me. In any case, I don't understand what rpmlint is trying to say ;(

...

I have updated the package,

Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-mitmproxy/python-mitmproxy-0.10-3.fc20.src.rpm

Comment 6 Fabian Affolter 2014-04-06 17:27:38 UTC
Sorry for the delay.

Comment 7 Fabian Affolter 2014-04-07 06:19:09 UTC
I'm unsure about the package name...from my point of view this is more a tool written in python than a python lib and because of that mitmproxy seems more suitable.

Comment 8 Fabian Affolter 2014-05-21 20:31:43 UTC
Any progress?

Comment 9 Dhiru Kholia 2014-06-01 06:49:32 UTC
Hi Fabian,

I am not finding much free time these days. It would be great if someone is able to step-up and take over this package.

Thanks!

Comment 10 Fabian Affolter 2015-03-04 19:04:11 UTC

*** This bug has been marked as a duplicate of bug 1198760 ***


Note You need to log in before you can comment on or make changes to this bug.