Bug 1069931 - Review Request: python-pytest-cache - pytest plugin with mechanisms for caching across test run
Summary: Review Request: python-pytest-cache - pytest plugin with mechanisms for cachi...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1069934 1069939
TreeView+ depends on / blocked
 
Reported: 2014-02-25 23:19 UTC by Orion Poplawski
Modified: 2014-03-06 16:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-06 16:15:43 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Orion Poplawski 2014-02-25 23:19:17 UTC
Spec URL: http:/www.cora.nwra.com/~orion/fedora/python-pytest-cache.spec
SRPM URL: http:/www.cora.nwra.com/~orion/fedora/python-pytest-cache-1.0-1.fc20.src.rpm
Description: 
pytest plugin with mechanisms for caching across test runs.

Fedora Account System Username: orion

http://koji.fedoraproject.org/koji/taskinfo?taskID=6571042

Comment 1 Parag AN(पराग) 2014-02-26 05:48:58 UTC
Thanks for the scratch build link.

1) rpmlint on generated rpms gave output
python3-pytest-cache.noarch: W: summary-not-capitalized C pytest plugin with mechanisms for caching across test runs
python-pytest-cache.noarch: W: summary-not-capitalized C pytest plugin with mechanisms for caching across test runs
python-pytest-cache.noarch: W: incoherent-version-in-changelog 0.2-1 ['1.0-1.fc21', '1.0-1']
python-pytest-cache.src: W: summary-not-capitalized C pytest plugin with mechanisms for caching across test runs
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

=> Fix the changelog version and summary warnings

2) Upstream source verified as (sha256sum)
upstream tarball: be7468edd4d3d83f1e844959fd6e3fd28e77a481440a7118d430130ea31b07a9
srpm tarball: be7468edd4d3d83f1e844959fd6e3fd28e77a481440a7118d430130ea31b07a9

3) License information in setup.py says GPL whereas LICENSE file says MIT and there is no other reference that says this package is licensed under MIT. Can this be clarified with upstream?

Comment 2 Orion Poplawski 2014-03-04 16:02:00 UTC
(In reply to Parag AN(पराग) from comment #1)
> Thanks for the scratch build link.
> 
> 1) rpmlint on generated rpms gave output
> python3-pytest-cache.noarch: W: summary-not-capitalized C pytest plugin with
> mechanisms for caching across test runs
> python-pytest-cache.noarch: W: summary-not-capitalized C pytest plugin with
> mechanisms for caching across test runs
> python-pytest-cache.noarch: W: incoherent-version-in-changelog 0.2-1
> ['1.0-1.fc21', '1.0-1']
> python-pytest-cache.src: W: summary-not-capitalized C pytest plugin with
> mechanisms for caching across test runs
> 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
> 
> => Fix the changelog version and summary warnings

Fixed.

> 3) License information in setup.py says GPL whereas LICENSE file says MIT
> and there is no other reference that says this package is licensed under
> MIT. Can this be clarified with upstream?

Upstream has clarified that it is MIT:

https://bitbucket.org/hpk42/pytest-cache/src/d588ecf39349e70d62cc19a603c00d7a339897bf/setup.py?at=default

Comment 3 Parag AN(पराग) 2014-03-05 04:57:35 UTC
Package Looks good then.

APPROVED.

Comment 4 Orion Poplawski 2014-03-05 05:20:08 UTC
New Package SCM Request
=======================
Package Name: python-pytest-cache
Short Description: Pytest plugin with mechanisms for caching across test run
Owners: orion
Branches: f19 f20 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-03-06 13:31:37 UTC
Git done (by process-git-requests).

Comment 6 Orion Poplawski 2014-03-06 16:15:43 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.