Spec URL: http://www.cora.nwra.com/~orion/fedora/python-pytest-flakes.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-pytest-flakes-0.2-1.fc20.src.rpm Description: py.test plugin for efficiently checking python source with pyflakes. Fedora Account System Username: orion
Review: + Package built successfully in mock rawhide + rpmlint on generated rpms gave output python3-pytest-flakes.noarch: W: spelling-error Summary(en_US) pyflakes -> flakes python3-pytest-flakes.noarch: W: summary-not-capitalized C pytest plugin to check source code with pyflakes python3-pytest-flakes.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-pytest-flakes.noarch: W: spelling-error %description -l en_US pyflakes -> flakes python-pytest-flakes.noarch: W: summary-not-capitalized C pytest plugin to check source code with pyflakes python-pytest-flakes.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-pytest-flakes.src: W: summary-not-capitalized C pytest plugin to check source code with pyflakes python-pytest-flakes.src: W: spelling-error %description -l en_US py -> pt, p, y 3 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball:9194712d8d0d01b871f68d33fa1e26ff717bb4a6f2b42891ac5d2baca6609558 upstream tarball:9194712d8d0d01b871f68d33fa1e26ff717bb4a6f2b42891ac5d2baca6609558 - unable to verify license tag + rest looks as per packaging guidelines Suggestions: 1) Summary can be capitalized like say "Pytest plugin...." 2) unable to find license tag or text in source files. Better add new source in spec and install https://raw.githubusercontent.com/fschulze/pytest-flakes/master/LICENSE
* Sat Mar 22 2014 Orion Poplawski <orion.com> - 0.2-2 - Capitalize summary/description - Add upstream license file Spec URL: http://www.cora.nwra.com/~orion/fedora/python-pytest-flakes.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-pytest-flakes-0.2-2.fc20.src.rpm
Looks good now. Thanks. APPROVED.
New Package SCM Request ======================= Package Name: python-pytest-flakes Short Description: Pytest plugin to check source code with pyflakes Owners: orion Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
Checked in and built. Thanks all.