Bug 1077295 - Review Request: perl-Exporter-Tiny - An exporter with the features of Sub::Exporter but only core dependencies
Summary: Review Request: perl-Exporter-Tiny - An exporter with the features of Sub::Ex...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1079614 (view as bug list)
Depends On:
Blocks: 1079617
TreeView+ depends on / blocked
 
Reported: 2014-03-17 16:20 UTC by Paul Howarth
Modified: 2014-04-06 09:57 UTC (History)
3 users (show)

Fixed In Version: perl-Exporter-Tiny-0.036-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-06 09:57:48 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2014-03-17 16:20:44 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Exporter-Tiny/branches/fedora/perl-Exporter-Tiny.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Exporter-Tiny/perl-Exporter-Tiny-0.036-2.fc21.src.rpm

Description:

Exporter::Tiny supports many of Sub::Exporter's external-facing features
including renaming imported functions with the -as, -prefix and -suffix
options; explicit destinations with the into option; and alternative
installers with the installer option. But it's written in only about 40%
as many lines of code and with zero non-core dependencies.

Its internal-facing interface is closer to Exporter.pm, with configuration
done through the @EXPORT, @EXPORT_OK and %EXPORT_TAGS package variables.

Exporter::Tiny performs most of its internal duties (including resolution of
tag names to sub names, resolution of sub names to coderefs, and installation
of coderefs into the target package) as method calls, which means they can be
overridden to provide interesting behavior.

Fedora Account System Username: pghmcfc

Note: this spec file targets EPEL-5 as well as modern Fedora, hence the use of old-fashioned spec elements

Comment 1 Parag AN(पराग) 2014-03-20 07:51:11 UTC
Review:

+ Package built successfully in mock rawhide

+ rpmlint on generated rpms gave output
perl-Exporter-Tiny.noarch: W: unexpanded-macro %description -l C %EXPORT_TAGS
perl-Exporter-Tiny.noarch: W: spelling-error %description -l en_US coderefs -> code refs, code-refs, recorders
perl-Exporter-Tiny.src: W: unexpanded-macro %description -l C %EXPORT_TAGS
perl-Exporter-Tiny.src: W: spelling-error %description -l en_US coderefs -> code refs, code-refs, recorders
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:e2e8d08ce4a959d3be3efdfac4cd6d57ff3ea38801b18b3a99c4b3df9306a3f7
upstream tarball:e2e8d08ce4a959d3be3efdfac4cd6d57ff3ea38801b18b3a99c4b3df9306a3f7

+ License is valid and included in

+ %check showed
All tests successful.

+ Package perl-Exporter-Tiny-0.036-2.fc21.noarch
Provides: perl(Exporter::Shiny) = 0.036 perl(Exporter::Tiny) = 0.036 perl-Exporter-Tiny = 0.036-2.fc21
Requires: perl >= 0:5.006001 perl(Exporter::Tiny) perl(strict) perl(warnings)

+ rest looks as per packaging guidelines

Suggestions:
1) Please correct the buildroot tag to one of the https://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag


APPROVED.

Comment 2 Paul Howarth 2014-03-20 10:14:15 UTC
New Package SCM Request
=======================
Package Name: perl-Exporter-Tiny
Short Description: An exporter with the features of Sub::Exporter but only core dependencies
Owners: pghmcfc
Branches: f19 f20 el5 el6 epel7
InitialCC: perl-sig

Thanks for the review Parag.

The buildroot tag is basically the same as the second one in the list in the guidelines, except with the use of the macro for the "id" command removed, bearing in mind that the guidelines also frown on the use of macros for standard system commands like "id".

Comment 3 Gwyn Ciesla 2014-03-20 11:50:18 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-03-20 13:03:34 UTC
perl-Exporter-Tiny-0.036-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Exporter-Tiny-0.036-2.el5

Comment 5 Fedora Update System 2014-03-20 13:03:42 UTC
perl-Exporter-Tiny-0.036-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Exporter-Tiny-0.036-2.el6

Comment 6 Fedora Update System 2014-03-20 13:03:52 UTC
perl-Exporter-Tiny-0.036-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Exporter-Tiny-0.036-2.fc19

Comment 7 Fedora Update System 2014-03-20 13:04:00 UTC
perl-Exporter-Tiny-0.036-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Exporter-Tiny-0.036-2.fc20

Comment 8 Ralf Corsepius 2014-03-22 05:20:50 UTC
*** Bug 1079614 has been marked as a duplicate of this bug. ***

Comment 9 Fedora Update System 2014-03-30 06:11:07 UTC
perl-Exporter-Tiny-0.036-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2014-03-30 06:13:06 UTC
perl-Exporter-Tiny-0.036-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 11 Fedora Update System 2014-04-05 19:36:09 UTC
perl-Exporter-Tiny-0.036-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 12 Fedora Update System 2014-04-05 19:36:57 UTC
perl-Exporter-Tiny-0.036-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.