Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Type-Tiny.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Type-Tiny-0.040-1.fc21.src.rpm Description: Type::Tiny is a tiny class for creating Moose-like type constraint objects which are compatible with Moo, Moose and Mouse. Fedora Account System Username: corsepiu
Taking.
=== KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=6664668 [x] Rpmlint output: [x] Package is not relocatable. [x] Buildroot is correct None specified, default used [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. e1b0730e699d03cd82c240d79f64635f Type-Tiny-0.040.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: fedora-rawhide-x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=6664668 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=108, Tests=1645, 18 wallclock secs ( 0.42 usr 0.10 sys + 15.75 cusr 1.39 csys = 17.66 CPU) Result: PASS Notes : I'm actually packaging a number of modules you've commented out (Class::Forward and Type::Tie, at least). Expect them submitted soon. APPROVED
(In reply to Emmanuel Seyman from comment #2) Thanks for the review. > Notes : I'm actually packaging a number of modules you've commented out > (Class::Forward and Type::Tie, at least). Expect them submitted soon. OK with me. FYI: In case it wasn't obvious, the sole purpose of the chain of submissions this package is part of, is to get perl-GnuPG-Interface (BZ #1079473) back on track, which is a dependency of another package, I am working on. I.e. co-maintainers rsp. maintainer to take over packages from this new chain of packages are more than welcome. I feel, I already maintain too many packages ;) New Package SCM Request ======================= Package Name: perl-Type-Tiny Short Description: Tiny, yet Moo(se)-compatible type constraint Owners: corsepiu Branches: f19 f20 InitialCC: perl-sig
Git done (by process-git-requests).
Package now is in rawhide. f20 and f19 will follow, when perl-Exporter-Tiny will be available in f20 rsp. f19.
perl-Type-Tiny-0.040-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Type-Tiny-0.040-1.fc20
perl-Type-Tiny-0.040-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Type-Tiny-0.040-1.fc19
perl-Type-Tiny-0.040-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Type-Tiny-0.040-1.fc19 has been pushed to the Fedora 19 stable repository.