Description of problem: If the node mcollective log file (/var/log/openshift/node/ruby193-mcollective.log with SCL) is missing, oo-diagnostics hangs in the test_node_mco_log check. How reproducible: Completely. Steps to Reproduce: 1. oo-diagnostics test_node_mco_log 2. mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ 3. oo-diagnostics test_node_mco_log Actual results: # oo-diagnostics test_node_mco_log NO ERRORS # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ # oo-diagnostics test_node_mco_log oo-diagnostics hangs here. Expected results: # oo-diagnostics test_node_mco_log NO ERRORS # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ # oo-diagnostics test_node_mco_log FAIL: test_node_mco_log No node mcollective log file found. 1 ERRORS # Additional info: PR: https://github.com/openshift/origin-server/pull/4983
Sorry; I should have filed this against Origin rather than Enterprise.
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/76ec64d3d08d93723e886e63cbec923c3b09aabe oo-diagnostics: Fix test_node_mco_log when no log Make test_node_mco_log fail gracefully when the node mcollective log file is absent. Before this commit, the test would hang because it would run a sed command with no input file provided. This commit fixes bug 1077664.
It's fixed, verified on devenv_4862, please refer to the following results: 1. make the node mcollective log files missed ~]# ls /var/log/openshift/node/*mcollective* ls: cannot access /var/log/openshift/node/*mcollective*: No such file or directory ~]#ls /var/log/*mcollective.log ls: cannot access /var/log/*mcollective.log: No such file or directory 2. oo-diagnostics test_node_mco_log -v <------snip-------> INFO: No node mcollective log file found. <------snip------->