Red Hat Bugzilla – Bug 1103294
oo-diagnostics can hang in test_node_mco_log if the node mcollective log file is absent
Last modified: 2014-07-28 11:16:31 EDT
+++ This bug was initially created as a clone of Bug #1077664 +++ Description of problem: If the node mcollective log file (/var/log/openshift/node/ruby193-mcollective.log with SCL) is missing, oo-diagnostics hangs in the test_node_mco_log check. How reproducible: Completely. Steps to Reproduce: 1. oo-diagnostics test_node_mco_log 2. mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ 3. oo-diagnostics test_node_mco_log Actual results: # oo-diagnostics test_node_mco_log NO ERRORS # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ # oo-diagnostics test_node_mco_log oo-diagnostics hangs here. Expected results: # oo-diagnostics test_node_mco_log NO ERRORS # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_ # oo-diagnostics test_node_mco_log FAIL: test_node_mco_log No node mcollective log file found. 1 ERRORS # Additional info: PR: https://github.com/openshift/origin-server/pull/4983 --- Additional comment from Miciah Dashiel Butler Masters on 2014-03-18 07:47:17 EDT --- Sorry; I should have filed this against Origin rather than Enterprise. --- Additional comment from openshift-github-bot on 2014-05-14 09:06:00 EDT --- Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/76ec64d3d08d93723e886e63cbec923c3b09aabe oo-diagnostics: Fix test_node_mco_log when no log Make test_node_mco_log fail gracefully when the node mcollective log file is absent. Before this commit, the test would hang because it would run a sed command with no input file provided. This commit fixes bug 1077664.
IMHO it's pretty bad when your diagnostics tool hangs, and this will be a more common scenario given OSE 2.1 logging capabilities.
PR: https://github.com/openshift/enterprise-server/pull/295 Merged into enterprise-2.1: https://github.com/openshift/enterprise-server/commit/c9053bbdd356a245fe8445e9cc2ed198423079cc
Verified on 2.1.z/2014-06-11.1 Steps to verify: 1.[root@node1 node]#oo-diagnostics test_node_mco_log -v 2.[root@node1 node]# mv ruby193-mcollective.log ruby193-mcollective.log_ 3.[root@node1 node]#oo-diagnostics test_node_mco_log -v Actual results: 1.Have info: INFO: loading list of installed packages INFO: OpenShift node installed. INFO: running: test_node_mco_log ----/var/log/openshift/node/ruby193-mcollective.log NO ERRORS 3.Have info about no log file: INFO: loading list of installed packages INFO: OpenShift node installed. INFO: running: test_node_mco_log INFO: No node mcollective log file found. INFO: skipping test_node_mco_log NO ERRORS
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0781.html