Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1103294

Summary:	oo-diagnostics can hang in test_node_mco_log if the node mcollective log file is absent
Product:	OpenShift Container Platform	Reporter:	Luke Meyer <lmeyer>
Component:	Containers	Assignee:	Miciah Dashiel Butler Masters <mmasters>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.1.0	CC:	adellape, bleanhar, jokerman, libra-onpremise-devel, misalunk, mmasters, mmccomas, pruan, yanpzhan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	If the /var/log/openshift/node/ruby193-mcollective.log file on a node host was missing, the oo-diagnostics tool hung during the test_node_mco_log check. This bug fix updates the oo-diagnostics tool to fail gracefully when the file is missing and report the error, and the tool no longer hangs as a result.	Story Points:	---
Clone Of:	1077664	Environment:
Last Closed:	2014-06-23 07:41:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1077664
Bug Blocks:

Description Luke Meyer 2014-05-30 15:50:17 UTC

+++ This bug was initially created as a clone of Bug #1077664 +++

Description of problem:

If the node mcollective log file (/var/log/openshift/node/ruby193-mcollective.log with SCL) is missing, oo-diagnostics hangs in the test_node_mco_log check.


How reproducible:

Completely.


Steps to Reproduce:

1. oo-diagnostics test_node_mco_log

2. mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_

3. oo-diagnostics test_node_mco_log


Actual results:

    # oo-diagnostics test_node_mco_log
    NO ERRORS
    # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_
    # oo-diagnostics test_node_mco_log

oo-diagnostics hangs here.


Expected results:

    # oo-diagnostics test_node_mco_log
    NO ERRORS
    # mv /var/log/openshift/node/ruby193-mcollective.log /var/log/openshift/node/ruby193-mcollective.log_
    # oo-diagnostics test_node_mco_log
    FAIL: test_node_mco_log
            No node mcollective log file found.
    
    1 ERRORS
    #


Additional info:

PR: https://github.com/openshift/origin-server/pull/4983

--- Additional comment from Miciah Dashiel Butler Masters on 2014-03-18 07:47:17 EDT ---

Sorry; I should have filed this against Origin rather than Enterprise.

--- Additional comment from openshift-github-bot on 2014-05-14 09:06:00 EDT ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/76ec64d3d08d93723e886e63cbec923c3b09aabe
oo-diagnostics: Fix test_node_mco_log when no log

Make test_node_mco_log fail gracefully when the node mcollective log file
is absent.  Before this commit, the test would hang because it would run
a sed command with no input file provided.

This commit fixes bug 1077664.

Comment 1 Luke Meyer 2014-05-30 15:51:23 UTC

IMHO it's pretty bad when your diagnostics tool hangs, and this will be a more common scenario given OSE 2.1 logging capabilities.

Comment 3 Miciah Dashiel Butler Masters 2014-06-10 16:54:21 UTC

PR: https://github.com/openshift/enterprise-server/pull/295

Merged into enterprise-2.1: https://github.com/openshift/enterprise-server/commit/c9053bbdd356a245fe8445e9cc2ed198423079cc

Comment 5 Yanping Zhang 2014-06-12 07:05:13 UTC

Verified on 2.1.z/2014-06-11.1

Steps to verify:
1.[root@node1 node]#oo-diagnostics test_node_mco_log -v


2.[root@node1 node]# mv ruby193-mcollective.log ruby193-mcollective.log_

3.[root@node1 node]#oo-diagnostics test_node_mco_log -v

Actual results:
1.Have info:
INFO: loading list of installed packages
INFO: OpenShift node installed.
INFO: running: test_node_mco_log
----/var/log/openshift/node/ruby193-mcollective.log
NO ERRORS

3.Have info about no log file:
INFO: loading list of installed packages
INFO: OpenShift node installed.
INFO: running: test_node_mco_log
INFO: No node mcollective log file found.
INFO: skipping test_node_mco_log
NO ERRORS

Comment 7 errata-xmlrpc 2014-06-23 07:41:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0781.html