Bug 1079616 - Review Request: perl-MooX - Using Moo and MooX:: packages the most lazy way
Summary: Review Request: perl-MooX - Using Moo and MooX:: packages the most lazy way
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1079618
TreeView+ depends on / blocked
 
Reported: 2014-03-22 05:04 UTC by Ralf Corsepius
Modified: 2014-04-09 01:02 UTC (History)
3 users (show)

Fixed In Version: perl-MooX-0.101-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-27 16:03:59 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2014-03-22 05:04:26 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-0.101-1.fc21.src.rpm
Description: 
Using Moo and MooX:: packages the most lazy way

Fedora Account System Username: corsepiu

Comment 1 Jean-Marie Renouard 2014-03-23 23:08:14 UTC
Hello,
I try to build your package on Fedora 20

 perl-Data-OptList-0.104-4.el6.noarch already installed and latest version
 perl-Module-Runtime-0.012-1.el6.noarch already installed and latest version

perl(Data::OptList) >= 0.107 are build required for perl-MooX-0.101-1.el6.noarch
perl(Module::Runtime) >= 0.013 are build required for perl-MooX-0.101-1.el6.noarch

Dependencies failed: perl-Moo, perl-Import-Into, perl-Test-More package 

This packages doesn't exist so I can't build your package with the last version Fedora 20.

Rpmlint output:
[makerpm@localhost SPECS]$ rpmlint perl-MooX.spec 
perl-MooX.spec:44: E: files-attr-not-set
perl-MooX.spec:45: E: files-attr-not-set
perl-MooX.spec:46: E: files-attr-not-set
perl-MooX.spec: W: no-cleaning-of-buildroot %clean
perl-MooX.spec: W: no-buildroot-tag
perl-MooX.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 3 errors, 3 warnings.

best regards,
Jean-Marie Renouard

Comment 2 Ralf Corsepius 2014-03-25 04:01:16 UTC
(In reply to Jean-Marie Renouard from comment #1)
> Hello,
> I try to build your package on Fedora 20
> 
>  perl-Data-OptList-0.104-4.el6.noarch already installed and latest version
>  perl-Module-Runtime-0.012-1.el6.noarch already installed and latest version

*.el6.* on F20? Fedora doesn't use el6 packages on F20.
This would indicate something is broken with your installation.

> Dependencies failed: perl-Moo, perl-Import-Into, perl-Test-More package 
> 
> This packages doesn't exist so I can't build your package with the last
> version Fedora 20.
These packages do exist under F20:

# repoquery -q --whatprovides 'perl(Import::Into)' 'perl(Moo)' 'perl(Test::More)'
perl-Import-Into-0:1.001001-3.fc20.noarch
perl-Moo-0:1.003001-2.fc20.noarch
perl-Test-Simple-0:1.001002-1.fc20.noarch

> Rpmlint output:
> [makerpm@localhost SPECS]$ rpmlint perl-MooX.spec 
> perl-MooX.spec:44: E: files-attr-not-set
> perl-MooX.spec:45: E: files-attr-not-set
> perl-MooX.spec:46: E: files-attr-not-set
> perl-MooX.spec: W: no-cleaning-of-buildroot %clean
> perl-MooX.spec: W: no-buildroot-tag
> perl-MooX.spec: W: no-%clean-section
> 0 packages and 1 specfiles checked; 3 errors, 3 warnings.
These warnings/errors all are bogus. They are all referring to issues which do not apply on Fedora.

On my F20 rpmlint's output looks like this:
# rpmlint perl-MooX.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Are you sure, you are running Fedora 20? I am inclined to believe you are either running el6 or your installation is a mix of different distros.


Finally, the package builds without problems - Scatch builds:
Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6670768
F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6670773
F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6670788

Comment 3 Jean-Marie Renouard 2014-03-25 06:38:29 UTC
Hello Raph,
ALL my apologies, I obtain similar results with Fedora 20.

I will make several tests to check this module installation.
Thank you for you' feedback.

Comment 4 Jean-Marie Renouard 2014-03-25 06:39:05 UTC
Hello Raph,
ALL my apologies, I obtain similar results with Fedora 20.

I will make several tests to check this module installation.
Thank you for you' feedback.

Comment 5 David Dick 2014-03-25 08:28:07 UTC
Dependencies:

FIX: BR perl(FindBin)                     # t/02-importparams.t line 8
FIX: BR perl(lib)                         # t/02-importparams.t line 9

TODO: add version to BR perl(ExtUtils::MakeMaker) >= 6.30 # Makefile.PL line 7

This version is so old that it is irrelevant unless you wanted EL5, which this package is obviously not intended for.

Comment 6 Ralf Corsepius 2014-03-25 12:02:02 UTC
(In reply to David Dick from comment #5)
Good catches - BR:s updated accordingly

Updated package:
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-0.101-2.fc21.src.rpm

Comment 7 Jean-Marie Renouard 2014-03-25 23:29:38 UTC
ok not problem for Me.
rpmlint ok 
build package release 2 on FC20 =>ok
Dependencies issues no longer meet. 

Best regards,
Jean-Marie Renouard

Comment 8 David Dick 2014-03-26 06:35:40 UTC
Okay.  One last thing i have to mention, though i presume you are aware of it.

TODO: Use DESTDIR instead of PERL_INSTALL_ROOT

Fix this or not, at your pleasure.

APPROVED!

Comment 9 Ralf Corsepius 2014-03-27 12:58:15 UTC
Thanks all for the review and comments.

New Package SCM Request
=======================
Package Name: perl-MooX
Short Description: Using Moo and MooX:: packages the most lazy way
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig

Comment 10 Gwyn Ciesla 2014-03-27 13:08:30 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-03-27 16:03:20 UTC
perl-MooX-0.101-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-MooX-0.101-2.fc20

Comment 12 Fedora Update System 2014-03-27 16:03:35 UTC
perl-MooX-0.101-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MooX-0.101-2.fc19

Comment 13 Fedora Update System 2014-04-09 00:55:53 UTC
perl-MooX-0.101-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-04-09 01:02:34 UTC
perl-MooX-0.101-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.