Bug 1079618 - Review Request: perl-MooX-late - Easily translate Moose code to Moo
Summary: Review Request: perl-MooX-late - Easily translate Moose code to Moo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1079615 1079616 1079617
Blocks: 1079473
TreeView+ depends on / blocked
 
Reported: 2014-03-22 05:27 UTC by Ralf Corsepius
Modified: 2014-05-17 06:30 UTC (History)
3 users (show)

Fixed In Version: perl-MooX-late-0.014-3.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-19 05:24:15 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2014-03-22 05:27:42 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-late.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-late-0.014-1.fc21.src.rpm
Description: 
Moo is a light-weight object oriented programming framework which aims to
be compatible with Moose. It does this by detecting when Moose has been  
loaded, and automatically "inflating" its classes and roles to full Moose
classes and roles. This way, Moo classes can consume Moose roles, Moose  
classes can extend Moo classes, and so forth.

Fedora Account System Username: corsepiu

Comment 1 David Dick 2014-03-30 06:40:22 UTC
koji rawhide build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6688141

FIX:

BR: Moo::Role - t/04arrayofattrs.t line 29
BR: Types::Standard - t/07coerce1.t line 23
BR: Cwd - inc/Module/Install.pm line 22 - used in Makefile.PL line 1
BR: File::Find - inc/Module/Install.pm line 23 - used in Makefile.PL line 1
BR: File::Path - inc/Module/Install.pm line 24 - used in Makefile.PL line 1
BR: vars - inc/Module/Install.pm line 26 - used in Makefile.PL line 1

TODO:

Replacing PERL_INSTALL_ROOT with DESTDIR
Including the examples directory in documentation

Comment 3 David Dick 2014-04-01 10:21:34 UTC
Still missing 

BR: Cwd - inc/Module/Install.pm line 22 - used in Makefile.PL line 1

Comment 4 Ralf Corsepius 2014-04-01 13:44:26 UTC
(In reply to David Dick from comment #3)
> Still missing 
> 
> BR: Cwd - inc/Module/Install.pm line 22 - used in Makefile.PL line 1

I am going to add this pedantic and childish absurdity, but please do me the favor of furtheron not participating in reviewing my packages.

Comment 6 David Dick 2014-04-02 07:20:26 UTC
Ok.

APPROVED.

Comment 7 David Dick 2014-04-17 11:31:08 UTC
Ralf, just a ping on this one for an SCM request.

Comment 8 Ralf Corsepius 2014-04-17 23:51:25 UTC
(In reply to David Dick from comment #7)
> Ralf, just a ping on this one for an SCM request.

Sorry, I had missed the approval in the 1000s of BZ/bodhi/Koji emails I've been receiving.

Anyway, thanks for the review.


New Package SCM Request
=======================
Package Name: perl-MooX-late
Short Description: Easily translate Moose code to Moo
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2014-04-18 11:48:38 UTC
Git done (by process-git-requests).

Comment 10 Ralf Corsepius 2014-04-19 05:24:15 UTC
Fixed in rawhide. 
F20 and F19 will follow should Fedora's release delay process ever free them.

Comment 11 Fedora Update System 2014-04-28 04:35:28 UTC
perl-MooX-late-0.014-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-MooX-late-0.014-3.fc20

Comment 12 Fedora Update System 2014-05-06 21:31:32 UTC
perl-MooX-late-0.014-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-05-07 03:46:55 UTC
perl-MooX-late-0.014-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MooX-late-0.014-3.fc19

Comment 14 Fedora Update System 2014-05-17 06:30:32 UTC
perl-MooX-late-0.014-3.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.