Bug 1083521 - NetworkManager bridge DHCP & ignore-carrier
Summary: NetworkManager bridge DHCP & ignore-carrier
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Williams
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1083624
TreeView+ depends on / blocked
 
Reported: 2014-04-02 11:53 UTC by poma
Modified: 2014-04-15 22:30 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
: 1083624 (view as bug list)
Environment:
Last Closed: 2014-04-15 22:30:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
NetworkManager bridge DHCP OK (116.37 KB, text/plain)
2014-04-02 11:56 UTC, poma
no flags Details
NetworkManager bridge DHCP with ignore-carrier (95.30 KB, text/plain)
2014-04-02 11:57 UTC, poma
no flags Details
0001-core-fix-bug-with-ignore-carrier-and-master-slave-de.patch (1.38 KB, patch)
2014-04-02 14:17 UTC, Dan Williams
no flags Details | Diff
NetworkManager bridge DHCP with ignore-carrier OK (114.02 KB, text/plain)
2014-04-02 15:59 UTC, poma
no flags Details

Description poma 2014-04-02 11:53:36 UTC
If it is utilised, ignore-carrier=* breaks DHCP of the bridges.

Comment 1 poma 2014-04-02 11:56:14 UTC
Created attachment 881751 [details]
NetworkManager bridge DHCP OK

Comment 2 poma 2014-04-02 11:57:05 UTC
Created attachment 881752 [details]
NetworkManager bridge DHCP with ignore-carrier

Comment 3 Dan Williams 2014-04-02 13:19:01 UTC
So even with ignore-carrier, DHCP requires an actual network connection, so it will wait until the carrier is on until it starts DHCP.  So NetworkManager is waiting for IP configurtion on the bridge until there is a carrier.

But I do see in your logs:

<info> (bridge0): link connected

and at this point NetworkManager *should* be starting DHCP on bridge0 but it doesn't.

What version of NetworkManager are you using, something from Fedora, or git master?

Comment 4 Dan Williams 2014-04-02 13:47:42 UTC
Nevermind, found the problem.

Comment 5 Dan Williams 2014-04-02 14:17:53 UTC
Created attachment 881815 [details]
0001-core-fix-bug-with-ignore-carrier-and-master-slave-de.patch

Candidate patch

Comment 6 Dan Williams 2014-04-02 14:36:42 UTC
Pushed to git master after IRC acks.

Comment 7 poma 2014-04-02 15:59:41 UTC
Created attachment 881883 [details]
NetworkManager bridge DHCP with ignore-carrier OK

Comment 8 poma 2014-04-02 16:03:20 UTC
Tested with git commit 42499b5.
PASSED!
Thanks Dan.

Comment 9 poma 2014-04-02 16:22:35 UTC
(In reply to Dan Williams from comment #3)
> So even with ignore-carrier, DHCP requires an actual network connection, so
> it will wait until the carrier is on until it starts DHCP.  So
> NetworkManager is waiting for IP configurtion on the bridge until there is a
> carrier.
> 
> But I do see in your logs:
> 
> <info> (bridge0): link connected
> 
> and at this point NetworkManager *should* be starting DHCP on bridge0 but it
> doesn't.
> 
> What version of NetworkManager are you using, something from Fedora, or git
> master?

Nothing fancy schmancy really, 
rebased & rebuild Rawhide's 'NetworkManager-0.9.9.1-4.git20140319.fc21.src.rpm' with a latest git commit tarballed at a certain time, 
e.g. 
'NetworkManager-0.9.9.1.git20140402.42499b5.tar.bz2' ,
'NetworkManager-0.9.9.1.git20140401.e9fdfa1.tar.bz2' , 
etc.


Note You need to log in before you can comment on or make changes to this bug.