Description of problem: When setting at TMPDIR to a path that contains a white space, supermin is failing with an error. Version-Release number of selected component (if applicable): supermin: 5.1.6 libguestfs: 1.26.0 How reproducible: Set TMPDIR to a path that includes a white space and try to use virt virt-sparsify Steps to Reproduce: 1. export TMPDIR="/tmp/foo bar" 2. Run virt-sparsify Actual results: Fails with: supermin: ext2: creating empty ext2 filesystem '/media/bigon/Little disk/.guestfs-1000/appliance.d.p4ovrvj6/root' mke2fs: invalid blocks 'disk/.guestfs-1000/appliance.d.p4ovrvj6/root' on device '/media/bigon/Little' Expected results: The appliance is built and virt-sparsify can run Additional info:
There was missing quoting around the call out to mke2fs. I have fix it in this commit: https://github.com/libguestfs/supermin/commit/ae88217aa64f1924ff88941d2ad0ce1aa6ad7fc4 I tested libguestfs-test-tool with this and TMPDIR pointing to a directory containing a space, and everything else seems to work.