Bug 1085330 - volume creation fails with "brick path is too long" in weird circumstances
Summary: volume creation fails with "brick path is too long" in weird circumstances
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: x86_64
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact:
URL:
Whiteboard:
: 840349 (view as bug list)
Depends On: 1071377
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-08 11:38 UTC by Atin Mukherjee
Modified: 2014-11-11 08:29 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1071377
Environment:
Last Closed: 2014-11-11 08:29:35 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2014-04-08 11:53:41 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Atin Mukherjee 2014-04-08 11:59:23 UTC
Please note with the current design of volfile it can not be guaranteed that volname and brickpath can have upto _POSIX_PATH_MAX characters. The validation goes like : strlen(volname) + strlen(brickpath) + strlen(hostname/ip) <= _POSIX_PATH_MAX.

Comment 3 Anand Avati 2014-04-15 08:37:24 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2014-04-15 10:06:50 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2014-04-23 04:53:58 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2014-04-23 06:11:59 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2014-04-29 06:13:29 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#6) for review on master by Atin Mukherjee (amukherj)

Comment 8 Anand Avati 2014-04-29 07:29:02 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative path name instead of absolute pathname) posted (#7) for review on master by Atin Mukherjee (amukherj)

Comment 9 Anand Avati 2014-04-30 08:05:24 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative pathname instead of absolute pathname) posted (#8) for review on master by Atin Mukherjee (amukherj)

Comment 10 Anand Avati 2014-05-01 13:59:29 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Length check for volume name and brick path is done on relative pathname instead of absolute pathname) posted (#9) for review on master by Atin Mukherjee (amukherj)

Comment 11 Anand Avati 2014-05-01 15:04:48 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Volname, brickpath & volfpath length validation) posted (#10) for review on master by Atin Mukherjee (amukherj)

Comment 12 Anand Avati 2014-05-02 05:35:53 UTC
REVIEW: http://review.gluster.org/7420 (glusterd : Volname, brickpath & volfpath length validation) posted (#11) for review on master by Atin Mukherjee (amukherj)

Comment 13 Anand Avati 2014-05-03 15:20:13 UTC
COMMIT: http://review.gluster.org/7420 committed in master by Vijay Bellur (vbellur) 
------
commit e73fc9939aecfa9f7955653d02f12243aba02fc6
Author: Atin Mukherjee <amukherj>
Date:   Tue Apr 8 17:10:25 2014 +0530

    glusterd : Volname, brickpath & volfpath length validation
    
    While creating a volume and adding a brick validation for _POSIX_PATH_MAX is
    done on absolute pathname instead of relative pathname due to which a brickpath
    having less than _POSIX_PATH_MAX may also fail the validation if the directory
    length is greater than (_POSIX_PATH_MAX -strlen(brickpath/volume name).
    
    Also this fix addresses one cli response message correction which says the
    volume file is too long instead of brick path is too long (when brickpath
    length validation doesn't fail and vol file length validation fails.)
    
    It is also important to note that with the current design of volfile naming, it
    can not be guranteed that volname and brickpath can have max of _POSIX_PATH_MAX
    characters.
    
    Change-Id: I1283d1f9dea96ae797620002c8723719f26a866d
    BUG: 1085330
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/7420
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 14 Niels de Vos 2014-07-11 15:11:17 UTC
*** Bug 840349 has been marked as a duplicate of this bug. ***

Comment 15 Niels de Vos 2014-09-22 12:37:40 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 16 Niels de Vos 2014-11-11 08:29:35 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.