Spec URL: http://lsm5.fedorapeople.org/golang-github-openshift-go-systemd/golang-github-openshift-go-systemd.spec SRPM URL: http://lsm5.fedorapeople.org/golang-github-openshift-go-systemd/SRPMS/golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc21.src.rpm Description: Go bindings to systemd D-BUS APIs Fedora Account System Username: lsm5 $ rpmlint golang-github-openshift-go-systemd.spec SRPMS/golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc21.src.rpm RPMS/noarch/golang-github-openshift-go-systemd-devel-0-0.1.gitb71042d.fc21.noarch.rpm golang-github-openshift-go-systemd.spec:36: W: setup-not-quiet golang-github-openshift-go-systemd.src:36: W: setup-not-quiet 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6721247 --- This package will _not_ affect golang-github-coreos-go-systemd
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-openshift-go-systemd-devel [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Requires -------- golang-github-openshift-go-systemd-devel (rpmlib, GLIBC filtered): golang golang(github.com/godbus/go.dbus) Provides -------- golang-github-openshift-go-systemd-devel: golang(github.com/openshift/go-systemd/dbus) golang-github-openshift-go-systemd-devel Source checksums ---------------- https://github.com/openshift/go-systemd/archive/b71042dcb39d4f573694804a7378c3a8e6bdfbdb/go-systemd-b71042d.tar.gz : CHECKSUM(SHA256) this package : 2049a3d43400de5a2e41e3ecd0bd125083deb0e2537ea56fc9c856068c7fd274 CHECKSUM(SHA256) upstream package : 2049a3d43400de5a2e41e3ecd0bd125083deb0e2537ea56fc9c856068c7fd274 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 1085873 -m fedora-rawhide-x86_64
One additional comment: Can you note in the spec file it's a fork of the coreos version? Or perhaps better summarize upstream briefly in a README-fork.md or something the rationale for the fork?
(In reply to Colin Walters from comment #2) > One additional comment: Can you note in the spec file it's a fork of the > coreos version? Or perhaps better summarize upstream briefly in a > README-fork.md or something the rationale for the fork? perhaps better to update the description itself like so: "Go bindings to systemd D-BUS APIs - OpenShift fork" this would also show the difference from coreos/go-systemd in a yum search comments?
New Package SCM Request ======================= Package Name: golang-github-openshift-go-systemd Short Description: Go bindings to systemd D-BUS APIs Owners: lsm5 Branches: f19 f20 el6 epel7 InitialCC: golang-sig
Git done (by process-git-requests).
golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc20
golang-github-openshift-go-systemd-0-0.1.gitb71042d.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-openshift-go-systemd-0-0.1.gitb71042d.el6
golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-openshift-go-systemd-0-0.1.gitb71042d.fc19
golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc20
golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19
Package golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-5115/golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19 then log in and leave karma (feedback).
golang-github-openshift-go-systemd-0-0.1.gitb71042d.el6 has been pushed to the Fedora EPEL 6 stable repository.
golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-openshift-go-systemd-0-0.2.gitb71042d.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.