Spec URL: http://lsm5.fedorapeople.org/geard/geard.spec SRPM URL: http://lsm5.fedorapeople.org/geard/SRPMS/geard-0-0.1.fc21.src.rpm Description: geard is an opinionated tool for installing Docker images as containers onto a systemd-enabled Linux operating system (systemd 207 or newer). Fedora Account System Username: lsm5
just fyi, all deps have been submitted as buildroot overrides
There's some bits in this spec file that I'm not sure are necessary, e.g.: %global __os_install_post %{_rpmconfigdir}/brp-compress # btrfs not available for rhel yet As for: %description %{summary} Now for a lot of shared libraries I think this is fine, but this package probably merits a bit of an attempt at a description =) Just take the upstream "A client and daemon for installing and linking Docker containers into systemd across hosts" ? Can also just drop: %if 0%{?rhel} #%patch0 -p1 -b ignore-btrfs-for-rhel #%patch90 -p1 -b docker-0.9-el6-lxc %endif #%patch1 -p1 -b upstream-patched-archive-tar And drop: %pre %post %preun %postun Theoretically we should use %systemd_postun and such right? <lsm5 Missing a trailing >
aah yup, i copied over the docker-io spec file so that's why most of the mess, cleaned up now: Spec URL: http://lsm5.fedorapeople.org/geard/geard.spec SRPM URL: http://lsm5.fedorapeople.org/geard/SRPMS/geard-0-0.2.gitb31df16.fc21.src.rpm
* This bit looks unused: %if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 %bcond_without systemd %endif * And this comment doesn't apply: # btrfs not available for rhel yet * As you mentioned on IRC the %description should be filled in. Other than that, looks like it's following the guidelines to me. Marking as fedora-review+ under the assumption these minor bits can be fixed.
Done. Thanks! Spec URL: http://lsm5.fedorapeople.org/geard/geard.spec SRPM URL: http://lsm5.fedorapeople.org/geard/SRPMS/geard-0-0.3.gitb31df16.fc21.src.rpm
New Package SCM Request ======================= Package Name: geard Short Description: CLI client for installing Docker images as containers Owners: lsm5 Branches: f19 f20 el6 epel7 InitialCC: golang-sig
Git done (by process-git-requests).
geard-0-0.3.gitb31df16.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/geard-0-0.3.gitb31df16.fc20
geard-0-0.3.gitb31df16.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/geard-0-0.3.gitb31df16.fc19
geard-0-0.3.gitb31df16.fc20 has been pushed to the Fedora 20 testing repository.
Jessica, copying you to this bug. It'll send out an email notification when geard gets pushed to stable, so you'll know when to update the geard install instructions
geard-0-0.3.gitb31df16.fc19 has been pushed to the Fedora 19 stable repository.
geard-0-0.3.gitb31df16.fc20 has been pushed to the Fedora 20 stable repository.