Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1086097

Summary:	[RFE] Allow the usage of the wildcard character '*' to the options "nfs.rpc-auth-allow" and "nfs.rpc-auth-reject"
Product:	[Community] GlusterFS	Reporter:	Poornima G <pgurusid>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	agunn, asrivast, bugs, gluster-bugs, joe.lin, pgurusid, shaines, ssaha, ssamanta, vagarwal, vbellur
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1018894
Clones:	1115369 (view as bug list)		Environment:
Last Closed:	2014-11-11 08:29:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1018894
Bug Blocks:	1115369

Description Poornima G 2014-04-10 05:46:30 UTC

+++ This bug was initially created as a clone of Bug #1018894 +++

Description of problem:
The ability to use "*" as a wildcard in the "nfs.rpc-auth-allow", and "nfs.rpc-auth-reject" list.

Version-Release number of selected component (if applicable):
glusterfs-server-3.4.0.33rhs-1

How reproducible:
Consistently 

Steps to Reproduce:
1. Create a Gluster volume
2. Run the "gluster volume set <VOL_NAME> nfs.rpc-auth-allow *.example.com

Actual results:
[root@rhsn1 ~]# gluster volume set rep_test_vol00 nfs.rpc-auth-allow *.example.com
volume set: failed: option rpc-auth.addr.rep_test_vol00.allow *.example.com: '*.example.com' is not a valid internet-address-list

Expected results:
volume set: success

Additional Information:
N/A

--- Additional comment from Sayan Saha on 2014-01-23 16:22:33 EST ---

Target this for Denali

Comment 1 Anand Avati 2014-04-10 05:46:59 UTC

REVIEW: http://review.gluster.org/7431 (common-utils: valid_host_name() now allows wildcards(*/?/[]) in hostname.) posted (#1) for review on master by Poornima G (pgurusid)

Comment 2 Anand Avati 2014-04-15 10:58:16 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 3 Anand Avati 2014-04-16 10:33:01 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#2) for review on master by Santosh Pradhan (spradhan)

Comment 4 Anand Avati 2014-04-18 10:30:56 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#3) for review on master by Santosh Pradhan (spradhan)

Comment 5 Anand Avati 2014-04-20 10:24:33 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#4) for review on master by Santosh Pradhan (spradhan)

Comment 6 Anand Avati 2014-04-21 08:45:25 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#5) for review on master by Santosh Pradhan (spradhan)

Comment 7 Anand Avati 2014-04-21 09:22:01 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#6) for review on master by Santosh Pradhan (spradhan)

Comment 8 Anand Avati 2014-04-21 10:41:12 UTC

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#7) for review on master by Santosh Pradhan (spradhan)

Comment 9 Anand Avati 2014-04-23 06:40:37 UTC

COMMIT: http://review.gluster.org/7485 committed in master by Vijay Bellur (vbellur) 
------
commit 00e247ee44067f2b3e7ca5f7e6dc2f7934c97181
Author: Santosh Kumar Pradhan <spradhan>
Date:   Wed Apr 9 10:19:43 2014 +0530

    gNFS: Support wildcard in RPC auth allow/reject
    
    RFE: Support wildcard in "nfs.rpc-auth-allow" and
    "nfs.rpc-auth-reject". e.g.
      *.redhat.com
      192.168.1[1-5].*
      192.168.1[1-5].*, *.redhat.com, 192.168.21.9
    
      Along with wildcard, support for subnetwork or IP range e.g.
      192.168.10.23/24
    
    The option will be validated for following categories:
    1) Anonymous i.e. "*"
    2) Wildcard pattern i.e. string containing any ('*', '?', '[')
    3) IPv4 address
    4) IPv6 address
    5) FQDN
    6) subnetwork or IPv4 range
    
    Currently this does not support IPv6 subnetwork.
    
    Change-Id: Iac8caf5e490c8174d61111dad47fd547d4f67bf4
    BUG: 1086097
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/7485
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 11 Niels de Vos 2014-09-22 12:37:49 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 12 Niels de Vos 2014-11-11 08:29:44 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users