Bug 1115369 - [3.5.2] Allow the usage of the wildcard character '*' to the options "nfs.rpc-auth-allow" and "nfs.rpc-auth-reject"
Summary: [3.5.2] Allow the usage of the wildcard character '*' to the options "nfs.rpc...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: 3.5.1
Hardware: x86_64
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1086097
Blocks: glusterfs-3.5.2
TreeView+ depends on / blocked
 
Reported: 2014-07-02 09:14 UTC by Niels de Vos
Modified: 2015-12-01 16:45 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.5.2beta1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1086097
Environment:
Last Closed: 2014-07-31 11:43:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2014-07-02 09:14:51 UTC
+++ This bug was initially created as a clone of Bug #1086097 +++

+++ This bug was initially created as a clone of Bug #1018894 +++

Description of problem:
The ability to use "*" as a wildcard in the "nfs.rpc-auth-allow", and "nfs.rpc-auth-reject" list.

Version-Release number of selected component (if applicable):
glusterfs-server-3.4.0.33rhs-1

How reproducible:
Consistently 

Steps to Reproduce:
1. Create a Gluster volume
2. Run the "gluster volume set <VOL_NAME> nfs.rpc-auth-allow *.example.com

Actual results:
[root@rhsn1 ~]# gluster volume set rep_test_vol00 nfs.rpc-auth-allow *.example.com
volume set: failed: option rpc-auth.addr.rep_test_vol00.allow *.example.com: '*.example.com' is not a valid internet-address-list

Expected results:
volume set: success

Additional Information:
N/A

--- Additional comment from Sayan Saha on 2014-01-23 16:22:33 EST ---

Target this for Denali

--- Additional comment from Anand Avati on 2014-04-10 07:46:59 CEST ---

REVIEW: http://review.gluster.org/7431 (common-utils: valid_host_name() now allows wildcards(*/?/[]) in hostname.) posted (#1) for review on master by Poornima G (pgurusid)

--- Additional comment from Anand Avati on 2014-04-15 12:58:16 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#1) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-16 12:33:01 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#2) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-18 12:30:56 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#3) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-20 12:24:33 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#4) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-21 10:45:25 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#5) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-21 11:22:01 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#6) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-21 12:41:12 CEST ---

REVIEW: http://review.gluster.org/7485 (gNFS: Support wildcard in RPC auth allow/reject) posted (#7) for review on master by Santosh Pradhan (spradhan)

--- Additional comment from Anand Avati on 2014-04-23 08:40:37 CEST ---

COMMIT: http://review.gluster.org/7485 committed in master by Vijay Bellur (vbellur) 
------
commit 00e247ee44067f2b3e7ca5f7e6dc2f7934c97181
Author: Santosh Kumar Pradhan <spradhan>
Date:   Wed Apr 9 10:19:43 2014 +0530

    gNFS: Support wildcard in RPC auth allow/reject
    
    RFE: Support wildcard in "nfs.rpc-auth-allow" and
    "nfs.rpc-auth-reject". e.g.
      *.redhat.com
      192.168.1[1-5].*
      192.168.1[1-5].*, *.redhat.com, 192.168.21.9
    
      Along with wildcard, support for subnetwork or IP range e.g.
      192.168.10.23/24
    
    The option will be validated for following categories:
    1) Anonymous i.e. "*"
    2) Wildcard pattern i.e. string containing any ('*', '?', '[')
    3) IPv4 address
    4) IPv6 address
    5) FQDN
    6) subnetwork or IPv4 range
    
    Currently this does not support IPv6 subnetwork.
    
    Change-Id: Iac8caf5e490c8174d61111dad47fd547d4f67bf4
    BUG: 1086097
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/7485
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-07-02 09:30:16 UTC
REVIEW: http://review.gluster.org/8223 (gNFS: Support wildcard in RPC auth allow/reject) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-07-02 11:28:30 UTC
COMMIT: http://review.gluster.org/8223 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit f25c549c959e06e70eefc5744dc5f93668411de2
Author: Niels de Vos <ndevos>
Date:   Wed Jul 2 11:11:43 2014 +0200

    gNFS: Support wildcard in RPC auth allow/reject
    
    RFE: Support wildcard in "nfs.rpc-auth-allow" and
    "nfs.rpc-auth-reject". e.g.
      *.redhat.com
      192.168.1[1-5].*
      192.168.1[1-5].*, *.redhat.com, 192.168.21.9
    
      Along with wildcard, support for subnetwork or IP range e.g.
      192.168.10.23/24
    
    The option will be validated for following categories:
    1) Anonymous i.e. "*"
    2) Wildcard pattern i.e. string containing any ('*', '?', '[')
    3) IPv4 address
    4) IPv6 address
    5) FQDN
    6) subnetwork or IPv4 range
    
    Currently this does not support IPv6 subnetwork.
    
    Cherry-picked from 00e247ee44067f2b3e7ca5f7e6dc2f7934c97181:
    > Change-Id: Iac8caf5e490c8174d61111dad47fd547d4f67bf4
    > BUG: 1086097
    > Signed-off-by: Santosh Kumar Pradhan <spradhan>
    > Reviewed-on: http://review.gluster.org/7485
    > Reviewed-by: Poornima G <pgurusid>
    > Reviewed-by: Harshavardhana <harsha>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Vijay Bellur <vbellur>
    
    Change-Id: I18ef0a914cd403c1f9e66d1b03ecd29465cbce95
    BUG: 1115369
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8223
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Santosh Pradhan <spradhan>

Comment 3 Anand Avati 2014-07-04 02:22:33 UTC
REVIEW: http://review.gluster.org/8233 (Remove escape chars from test) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2014-07-04 05:54:58 UTC
REVIEW: http://review.gluster.org/8235 (tests: support regex in EXPECT constructs) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 5 Anand Avati 2014-07-04 07:44:08 UTC
COMMIT: http://review.gluster.org/8235 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit bf737d691cf812b40594e64c4c52f3c677a04e35
Author: Pranith Kumar K <pkarampu>
Date:   Fri Jul 4 11:23:12 2014 +0530

    tests: support regex in EXPECT constructs
    
                Backport of http://review.gluster.org/6788
    
    Instead of just strings, provide the ability to specify a regex
    of the pattern to expect
    
    Change-Id: I288db2290612accd795c3498f74e8b70bab21f2c
    BUG: 1115369
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8235
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Niels de Vos 2014-07-21 15:42:02 UTC
The first (and last?) Beta for GlusterFS 3.5.2 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.2beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-devel/2014-July/041636.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-07-31 11:43:39 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.2, please reopen this bug report.

glusterfs-3.5.2 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-July/041217.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.