Spec URL: http://codeblock.fedorapeople.org/packages/ghc-optparse-applicative/ghc-optparse-applicative.spec SRPM URL: http://codeblock.fedorapeople.org/packages/ghc-optparse-applicative/ghc-optparse-applicative-0.8.0.1-1.fc20.src.rpm Description: Utilities and combinators for parsing command line options. This package provides the Haskell optparse-applicative library development files. Fedora Account System Username: codeblock
Latest hjsmin depends on this.
64 reverse deps on Hackage: http://packdeps.haskellers.com/reverse/optparse-applicative (Latest Elm no longer uses hjsmin though.)
Do you want to post a koji scratch build?
Sure, build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6739403
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1167360 bytes in 89 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Waiving this given that our current packaging/macros don't support doc subpackaging really - we should probably address this for F21. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 21 files have unknown license. Detailed output of licensecheck in /home/petersen/pkgreview/ghc-optparse-applicative-ghc- optparse-applicative/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. It would be good to add %check with a comment that testsuite requires unpackaged deps to run [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1259520 bytes in /usr/share Waiving for now - see above on -oc. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-optparse-applicative-0.8.0.1-1.fc21.x86_64.rpm ghc-optparse-applicative-devel-0.8.0.1-1.fc21.x86_64.rpm ghc-optparse-applicative-0.8.0.1-1.fc21.src.rpm ghc-optparse-applicative.x86_64: W: spelling-error Summary(en_US) combinators -> combinations, combination, contaminators ghc-optparse-applicative.x86_64: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators ghc-optparse-applicative.src: W: spelling-error Summary(en_US) combinators -> combinations, combination, contaminators ghc-optparse-applicative.src: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators ghc-optparse-applicative.src: W: strange-permission optparse-applicative-0.8.0.1.tar.gz 0600L I'd like to track down where these are coming! 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-optparse-applicative ghc-optparse-applicative-devel ghc-optparse-applicative.x86_64: W: spelling-error Summary(en_US) combinators -> combinations, combination, contaminators ghc-optparse-applicative.x86_64: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- ghc-optparse-applicative (rpmlib, GLIBC filtered): ghc(ansi-wl-pprint-0.6.7.1-224eec9b3819d85bbf7dcc398a1b424b) ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(process-1.1.0.2-76e05340eb66705981411022731ca84a) ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) libHSansi-terminal-0.6-ghc7.6.3.so()(64bit) libHSansi-wl-pprint-0.6.7.1-ghc7.6.3.so()(64bit) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSdirectory-1.2.0.1-ghc7.6.3.so()(64bit) libHSfilepath-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit) libHSprocess-1.1.0.2-ghc7.6.3.so()(64bit) libHStime-1.4.0.1-ghc7.6.3.so()(64bit) libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit) libHSunix-2.6.0.1-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgmp.so.10()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) ghc-optparse-applicative-devel (rpmlib, GLIBC filtered): /bin/sh ghc(optparse-applicative-0.8.0.1-d300751341a2bdac332a2f64d4651dd9) ghc-compiler ghc-devel(ansi-wl-pprint-0.6.7.1-224eec9b3819d85bbf7dcc398a1b424b) ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc-devel(process-1.1.0.2-76e05340eb66705981411022731ca84a) ghc-devel(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) ghc-optparse-applicative(x86-64) Provides -------- ghc-optparse-applicative: ghc(optparse-applicative-0.8.0.1-d300751341a2bdac332a2f64d4651dd9) ghc-optparse-applicative ghc-optparse-applicative(x86-64) libHSoptparse-applicative-0.8.0.1-ghc7.6.3.so()(64bit) ghc-optparse-applicative-devel: ghc-devel(optparse-applicative-0.8.0.1-d300751341a2bdac332a2f64d4651dd9) ghc-optparse-applicative-devel ghc-optparse-applicative-devel(x86-64) ghc-optparse-applicative-static Unversioned so-files -------------------- ghc-optparse-applicative: /usr/lib64/ghc-7.6.3/optparse-applicative-0.8.0.1/libHSoptparse-applicative-0.8.0.1-ghc7.6.3.so Source checksums ---------------- http://hackage.haskell.org/package/optparse-applicative-0.8.0.1/optparse-applicative-0.8.0.1.tar.gz : CHECKSUM(SHA256) this package : 83874bc6e68abceab90380c29092ad0c488b55535d1e931b8a45db0c139767a6 CHECKSUM(SHA256) upstream package : 83874bc6e68abceab90380c29092ad0c488b55535d1e931b8a45db0c139767a6 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b ghc-optparse-applicative Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Package APPROVED It would be good to add %check with comment why testsuite can't be enabled yet.
New Package SCM Request ======================= Package Name: ghc-optparse-applicative Short Description: Utilities and combinators for parsing command line options Owners: codeblock petersen Branches: f20 epel7 f19 InitialCC: haskell-sig
Git done (by process-git-requests).
*** Bug 923622 has been marked as a duplicate of this bug. ***
ghc-optparse-applicative-0.8.0.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-optparse-applicative-0.8.0.1-2.fc20
ghc-optparse-applicative-0.8.0.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-optparse-applicative-0.8.0.1-2.fc19
ghc-optparse-applicative-0.8.0.1-2.fc19 has been pushed to the Fedora 19 testing repository.
ghc-optparse-applicative-0.8.0.1-2.fc20 has been pushed to the Fedora 20 stable repository.
ghc-optparse-applicative-0.8.0.1-2.fc19 has been pushed to the Fedora 19 stable repository.
ghc-optparse-applicative-0.11.0.1-2.el7,ghc-transformers-compat-0.3.3.4-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-optparse-applicative-0.11.0.1-2.el7,ghc-transformers-compat-0.3.3.4-2.el7
ghc-transformers-compat-0.3.3.4-2.el7, ghc-optparse-applicative-0.11.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
*** Bug 1256052 has been marked as a duplicate of this bug. ***