Spec URL: http://petersen.fedorapeople.org/reviews/happy.spec SRPM URL: http://petersen.fedorapeople.org/reviews/happy-1.18.10-34.fc18.src.rpm Description: Happy is a LALR(1) parser generator system for Haskell, similar to the tool `yacc' for C. Like `yacc', it takes a file containing an annotated BNF specification of a grammar and produces a Haskell module containing a parser for the grammar. Happy is flexible: you can have several Happy parsers in the same program, and several entry points to a single grammar. Happy can work in conjunction with a lexical analyser supplied by the user (either hand-written or generated by another program).
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6726892
This review is to pull happy out of haskell-platform into its own package. Original review is bug 223486. Happy is used to build Agda, haskell-src-exts, gtk2hs-buildtools, pandoc, and a couple more libraries.
APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/happy See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names (This will be fixed by necessity on import and results from decoupling this package from haskell-platform) - Uses parallel make %{?_smp_mflags} macro. (This should be fine as well, since it is just for docs. For the actual compilation process, we use cabal.) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 286720 bytes in 39 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: happy-1.18.10-34.fc20.x86_64.rpm happy-1.18.10-34.fc20.src.rpm happy.x86_64: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc happy.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers happy.x86_64: W: spelling-error %description -l en_US analyser -> analyses, analyzer, analysis happy.x86_64: W: no-manual-page-for-binary happy happy.src: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc happy.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers happy.src: W: spelling-error %description -l en_US analyser -> analyses, analyzer, analysis happy.src: W: strange-permission happy-1.18.10.tar.gz 0444L 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint happy happy.x86_64: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc happy.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers happy.x86_64: W: spelling-error %description -l en_US analyser -> analyses, analyzer, analysis happy.x86_64: W: no-manual-page-for-binary happy 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- happy (rpmlib, GLIBC filtered): ghc(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3) ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926) ghc(ghc-prim-0.3.0.0-d5221a8c8a269b66ab9a07bdc23317dd) ghc(integer-gmp-0.5.0.0-2f15426f5b53fe4c6490832f9b20d8d7) ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSmtl-2.1.2-ghc7.6.3.so()(64bit) libHSrts-ghc7.6.3.so()(64bit) libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) Provides -------- happy: happy happy(x86-64) Source checksums ---------------- http://hackage.haskell.org/package/happy-1.18.10/happy-1.18.10.tar.gz : CHECKSUM(SHA256) this package : c1c920f77906740252e261e2baec5b7519e584344d6080aa5a9cc0b677b9064b CHECKSUM(SHA256) upstream package : c1c920f77906740252e261e2baec5b7519e584344d6080aa5a9cc0b677b9064b Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b happy Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Package Change Request ====================== Package Name: happy New Branches: f20 f19 Owners: petersen InitialCC: haskell-sig
Git done (by process-git-requests).
Built for F21 Rawhide.
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, haskell-platform-2013.2.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2014-4579/alex-3.0.5-36.fc20,cabal-install-1.16.0.2-34.fc20,ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-parallel-3.2.0.3-34.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-compat-0.95.1-34.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-syb-0.4.0-35.fc20,ghc-transformers-0.3.0.0-33.fc20,happy-1.18.10-34.fc20,haskell-platform-2013.2.0.0-33.fc20
Package ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-async-2.0.1.4-30.fc20 ghc-html-1.0.1.2-28.fc20 ghc-HTTP-4000.2.8-32.fc20 ghc-HUnit-1.2.5.2-31.fc20 ghc-network-2.4.1.2-31.fc20 ghc-parsec-3.1.3-30.fc20 ghc-QuickCheck-2.6-32.fc20 ghc-regex-base-0.93.2-28.fc20 ghc-regex-posix-0.95.2-29.fc20 ghc-transformers-0.3.0.0-33.fc20 alex-3.0.5-36.fc20 cabal-install-1.16.0.2-34.fc20 ghc-parallel-3.2.0.3-34.fc20 ghc-regex-compat-0.95.1-34.fc20 ghc-syb-0.4.0-35.fc20 happy-1.18.10-34.fc20 haskell-platform-2013.2.0.0-36.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-4579/alex-3.0.5-36.fc20,cabal-install-1.16.0.2-34.fc20,ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-parallel-3.2.0.3-34.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-compat-0.95.1-34.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-syb-0.4.0-35.fc20,ghc-transformers-0.3.0.0-33.fc20,happy-1.18.10-34.fc20,haskell-platform-2013.2.0.0-36.fc20 then log in and leave karma (feedback).
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.