Spec URL: http://www.red-bean.com/~bos/happy.spec SRPM URL: http://www.red-bean.com/~bos/happy-1.16-1.src.rpm Description: [This is my first Extras contribution, and I need a package sponsor.] Happy is a parser generator system for Haskell, similar to the tool `yacc' for C. Like `yacc', it takes a file containing an annotated BNF specification of a grammar and produces a Haskell module containing a parser for the grammar. Happy is flexible: you can have several Happy parsers in the same program, and several entry points to a single grammar. Happy can work in conjunction with a lexical analyser supplied by the user (either hand-written or generated by another program), or it can parse a stream of characters directly (but this isn't practical in most cases).
Sorry for the slow review. Here are some comments: Rpmlint on the srpm gives: W: happy redundant-prefix-tag I think the dos2unix buildrequires can be dropped. Otherwise it looks ok to me.
Created attachment 148175 [details] happy.spec-1.patch If you can update the package, then I will do a formal review. :)
Ping :)
Sorry for the delay. Spec URL: http://www.red-bean.com/~bos/happy.spec SRPM URL: http://www.red-bean.com/~bos/happy-1.16-2.src.rpm
Here is the review: Good: + package and spec file are well named + meets Packaging Guidelines + package is open source (BSD-like) + license fields matches license and license file included in %doc + spec file is legible and in English + package built on i386 + buildrequires listed + no translations + no libs included + owns its directories + no duplicates in filelist + has %clean + consistent use of macros + packages contains code + documentation small enough to be main package + no runtime files in %doc + no devel files + does not own dirs or files owned by other packages + installs and runs ok Need attention: - md5sum does not match upstream tarball, please use that b9fd2f5eba61974dab8e12873cadee6f happy-1.16.tar.gz - rpmlint on srpm: W: happy strange-permission happy.spec 0600 - rpmlint from binary package W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/expr-eval/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/expr-tree/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/packing/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/bio-eg/Bio.y W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/expr-monad/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/bio-eg/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/hidden-leftrec/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/nlp/Makefile W: happy wrong-file-end-of-line-encoding /usr/share/doc/happy-1.16/examples/glr/highly-ambiguous/Makefile Maybe worth addressing: not sure how useful the examples are to include. They could also be dropped? - missing disttag Please suffix %{?dist} to the release field. - description Maybe remove "or it can parse a stream of characters directly (but this isn't practical in most cases)"?
Created attachment 150871 [details] happy.spec-2.patch
attached some minor additional suggested fixes
Jens, I've incorporated all of your suggestions, and the source and binary packages now both pass rpmlint completely cleanly. Please see the new spec and SRPM at the URLs in comment #4.
Ok, thanks for the updated package. (BTW in the future please bump the release field, since that makes it easier for the reviewer to look at the changes.) All points have been addressed, the package looks good to me. Package is APPROVED. Do you still need sponsorship? I would be happy to sponsor you if you can do at least one pre-review of a package waiting to be reviewed. Have you already applied for a fedora account?
Thanks for the approval. Yes, I still need sponsorship. I'll point you at a pre-reviewed package in a few hours. I *just* applied for a Fedora account (username bos).
For a package review, see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229728
You need to follow http://fedoraproject.org/wiki/Packaging/ReviewGuidelines to do a complete review. (When doing a pre-review - since you need to be a Contributor to do formal reviews - it is good to comment in the bug that it is a pre-review, so the submitter knows it is a pre-review.) Sorry the process is still a bit involved, but this is because (currently) every fedora contributor can review and approve new packages.
Anyway your comments look ok so far: while your Fedora Account is being processed, you can wait for the submitter to update the package.
New Package CVS Request ======================= Package Name: happy Short Description: Haskell parser generator Owners: bos Branches: FC-6 InitialCC: petersen
done
In devel now.
Package Change Request ====================== Package Name: happy New Branches: el6 Owners: bos petersen InitialCC: haskell-sig
Git done (by process-git-requests).