Bug 1088900 - Allow non-alphanumeric characters in shortcuts Program group name
Summary: Allow non-alphanumeric characters in shortcuts Program group name
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Installer
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ER3
: EAP 6.3.0
Assignee: Thomas Hauser
QA Contact: Petr Kremensky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-17 11:48 UTC by Petr Kremensky
Modified: 2017-10-10 00:15 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-06-28 15:30:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1089146 0 unspecified CLOSED [Doc Bug Fix] Document requirements for program group name. 2021-02-22 00:41:40 UTC

Internal Links: 1089146

Description Petr Kremensky 2014-04-17 11:48:32 UTC
Description of problem:
 non-alphanumeric characters are not allowed in shortcuts Program group name. Using these chracters is a common practise on windows (eg. 7-Zip, Jboss\eap). We can forbit user to use characters like ('#', '$', '%',...) in program group name, but we should allow them to use common characters used in path like ('/', '\', '_', '-').

Version-Release number of selected component (if applicable):
 EAP 6.3.0.ER1

How reproducible:
 Always

Steps to Reproduce:
 1. Run gui installer, go to shortcuts creation screen.
 2. Use "eap-test" for Program group name
 3. Finish the installation

Actual results:
 Error dialogue is thrown:
 "Please enter a alphanumeric string for your program group."

Expected results:
 User is able to use some special characters commonly used in path.

Comment 1 Petr Kremensky 2014-04-17 12:01:46 UTC
Increasing severity and requesting blocker flag.

This issue is critical for installation in Chinese and Japanese.
Default Program groups names for Chinese and Japanese are: 
 - JBoss 平台
 - JBoss プラットフォーム

Both values doesn't pass the validation.

Comment 2 Thomas Hauser 2014-04-17 15:17:56 UTC
This bug is a side effect of the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1033028

Comment 3 Miles Tjandrawidjaja 2014-04-17 16:32:54 UTC
Changes have been made to allow for different languages.
Character '-' and '_' are also allowed.

Slashes are like '/' and '\' are still not allowed, this is because windows does not allow slashes in its file and directory names.

http://git.app.eng.bos.redhat.com/git/izpack.git/commit/?h=izpack-wip&id=91040c8c075f0886277f64229740eeeb30a887d5

Comment 4 Petr Kremensky 2014-04-18 06:12:51 UTC
I tried this with EAP 6.2.0 (no restrictions) and actually it's RHEL where '/' and '\' characters are causing trouble. On windows both characters create a subdirectory in program group manu which is OK.

But IMO it's fine to allow only '-' and '_' characters here. I'll create a documentation BZ to add this restrictions into installation guide.

Comment 5 Miles Tjandrawidjaja 2014-04-22 20:12:47 UTC
I agree, I've made the changes to ensure slashes are not allowed in the program group.
http://git.app.eng.bos.redhat.com/git/izpack.git/commit/?h=izpack-wip&id=7fee386762ef480c4f28f5ccaf237fee09ea0510

Comment 6 Petr Kremensky 2014-04-25 08:08:42 UTC
I just noticed that empty program group is allowed with ER2 (BZ1033028), cannot any code covering this, can you please look into this.

Comment 7 Petr Kremensky 2014-04-25 08:26:54 UTC
*cannot see

Comment 8 Miles Tjandrawidjaja 2014-04-25 14:44:17 UTC
Added check to cover case where program group is empty.
http://git.app.eng.bos.redhat.com/git/izpack.git/commit/?h=izpack-wip

Comment 9 Petr Kremensky 2014-05-07 07:14:17 UTC
Verified on EAP 6.3.0.ER3 installer.


Note You need to log in before you can comment on or make changes to this bug.