Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://ddick.fedorapeople.org/packages/perl-Parse-DMIDecode.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Parse-DMIDecode-0.03-1.fc20.src.rpm Description: Interface to SMBIOS using dmidecode Fedora Account System Username: ddick
koji builds rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6776895 el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6776901
Re-opened. I needed to ExclusiveArch this package as the dmidecode package it depends uses one. Also, needed to skip pod testing on el6. Ready to go again. koji builds at rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6777078 el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6777077
removed the unnecessary debug builds. koji builds at rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6781764 el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6781767
A few quick comments before I go through the review checklist: The POD problem for EL-6 is https://rt.cpan.org/Public/Bug/Display.html?id=52296; the patch https://rt.cpan.org/Ticket/Attachment/699959/360879/fix-pod-urls.patch attached to that ticket fixes the issue and doesn't break other builds, so I think that would be a better fix than skipping the test on EL-6. Please add a spec comment about why setting %debug_package to %{nil} is desired (I know, but not everybody would get it). Use of macros for commands like %{__rm} is discouraged in the guidelines. Also, be aware that Nicola (upstream) hasn't updated any of her CPAN packages since January 2008, so if there's any bugs that need fixing, you're probably on your own. I know this as current maintainer of perl-RRD-Simple...
rpmlint ======= perl-Parse-DMIDecode.x86_64: E: no-binary This is to be expected; the package is really noarch but has to be arch-specific because its dependency, dmidecode, is not available on all architectures. Review Checks ============= - rpmlint OK - package and spec file naming OK - package meets guidelines - license is ASL 2.0, OK for Fedora and matches upstream - upstream provides license file and it's packaged as %doc - spec file is legible and written in English - source matches upstream, including timestamp - package builds OK in mock for F-19 .. Rawhide and EPEL-6 .. EPEL-7 (i386 and x86_64) - package is "ExclusiveArch: %{ix86} x86_64 ia64", with explanation included - build dependencies somewhat over-specified - see below - no locale data, libraries, devel files to concern ourselves with - no bundled libraries - package is not intended to be relocatable - directory ownership and permissions OK - no duplicate files - macro usage is consistent - code, not content - no large docs to worry about - docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all ASCII - no scriptlets or sub-packages Nits ==== perl(Cwd) and perl(File::Spec) are only needed by Makefile.PL, which you don't use, so there's no need to BuildRequire them. perl(Config) is not needed if AUTOMATED_TESTING is set at build time, which it is. perl(constant) is only used in the example code, so is not needed for the build. Build.PL asks for Test::Deep but it's not actually used. No blockers here. APPROVED.
(In reply to Paul Howarth from comment #4) > A few quick comments before I go through the review checklist: > > The POD problem for EL-6 is > https://rt.cpan.org/Public/Bug/Display.html?id=52296; the patch > https://rt.cpan.org/Ticket/Attachment/699959/360879/fix-pod-urls.patch > attached to that ticket fixes the issue and doesn't break other builds, so I > think that would be a better fix than skipping the test on EL-6. Agreed. Thanks for this. Applied. > Please add a spec comment about why setting %debug_package to %{nil} is > desired (I know, but not everybody would get it). Done. > Use of macros for commands like %{__rm} is discouraged in the guidelines. Okay. Removed. > Also, be aware that Nicola (upstream) hasn't updated any of her CPAN > packages since January 2008, so if there's any bugs that need fixing, you're > probably on your own. I know this as current maintainer of perl-RRD-Simple... Thanks for the warning.
(In reply to Paul Howarth from comment #5) > perl(Cwd) and perl(File::Spec) are only needed by Makefile.PL, which you > don't > use, so there's no need to BuildRequire them. Fair. Removed. > perl(Config) is not needed if AUTOMATED_TESTING is set at build time, which > it is. Done. > perl(constant) is only used in the example code, so is not needed for the > build. Done. > Build.PL asks for Test::Deep but it's not actually used. And done. > No blockers here. APPROVED. Thanks for the review Paul. Most appreciated.
New Package SCM Request ======================= Package Name: perl-Parse-DMIDecode Short Description: Interface to SMBIOS using dmidecode Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Parse-DMIDecode-0.03-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Parse-DMIDecode-0.03-1.fc20
perl-Parse-DMIDecode-0.03-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Parse-DMIDecode-0.03-1.el6
perl-Parse-DMIDecode-0.03-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-Parse-DMIDecode-0.03-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Parse-DMIDecode-0.03-1.el6 has been pushed to the Fedora EPEL 6 stable repository.