Spec URL: http://ddick.fedorapeople.org/packages/perl-Sys-Detect-Virtualization.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Sys-Detect-Virtualization-0.106-1.fc20.src.rpm Description: Detect if a UNIX system is running as a virtual machine Fedora Account System Username: ddick
Missing BRs: perl(Config) perl(ExtUtils::MM_Unix) Your package always run-requires Parse::DMIDecode; you want to remove line 41. Are the explicit run-requires in the virtdetect package necessary? It might not be obvious to the user that virtdetect is a subpackage of this one; maybe packaging the README in its own %doc would be a good idea?
(In reply to Petr Šabata from comment #1) > Missing BRs: > perl(Config) > perl(ExtUtils::MM_Unix) Done. > Your package always run-requires Parse::DMIDecode; you want to remove line > 41. *ouch* Done. > Are the explicit run-requires in the virtdetect package necessary? It was the only way i knew to remove the requires for Getopt::Long, POSIX, etc from perl-Sys-Detect-Virtualization (where they are not required) and keep them in virtdetect (where they are). Suggestions? > It might not be obvious to the user that virtdetect is a subpackage of this > one; maybe packaging the README in its own %doc would be a good idea? Okay. Along the same sort of line, i thought including the Changelog would be useful too?
(In reply to David Dick from comment #2) > (In reply to Petr Šabata from comment #1) > > Missing BRs: > > perl(Config) > > perl(ExtUtils::MM_Unix) > > Done. Check. > > Your package always run-requires Parse::DMIDecode; you want to remove line > > 41. > > *ouch* Done. Check. > > Are the explicit run-requires in the virtdetect package necessary? > > It was the only way i knew to remove the requires for Getopt::Long, POSIX, > etc from perl-Sys-Detect-Virtualization (where they are not required) and > keep them in virtdetect (where they are). Suggestions? You don't need to remove them at all; they're not there :) Just drop the req filters in the main package and explicit run requires in the virtdetect one. It will work like a charm. The dependencies (and provides) are put in the packages according to what files they include. > > It might not be obvious to the user that virtdetect is a subpackage of this > > one; maybe packaging the README in its own %doc would be a good idea? > > Okay. Along the same sort of line, i thought including the Changelog would > be useful too? Could be but I find it somewhat less important; the README points the user to the main package which is installed and provides the Changelog already.
(In reply to Petr Šabata from comment #3) > (In reply to David Dick from comment #2) > > (In reply to Petr Šabata from comment #1) > > > Are the explicit run-requires in the virtdetect package necessary? > > > > It was the only way i knew to remove the requires for Getopt::Long, POSIX, > > etc from perl-Sys-Detect-Virtualization (where they are not required) and > > keep them in virtdetect (where they are). Suggestions? > > You don't need to remove them at all; they're not there :) > Just drop the req filters in the main package and explicit run requires in > the virtdetect one. It will work like a charm. The dependencies (and > provides) are put in the packages according to what files they include. Hmmm... yes it does.. filters and explicit run requires removed. > > > It might not be obvious to the user that virtdetect is a subpackage of this > > > one; maybe packaging the README in its own %doc would be a good idea? > > > > Okay. Along the same sort of line, i thought including the Changelog would > > be useful too? > > Could be but I find it somewhat less important; the README points the user > to the main package which is installed and provides the Changelog already. Okay. removed Changelog file.
Approving.
New Package SCM Request ======================= Package Name: perl-Sys-Detect-Virtualization Short Description: Detect if a UNIX system is running as a virtual machine Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Thanks for the review Petr.
Git done (by process-git-requests).
perl-Sys-Detect-Virtualization-0.106-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Sys-Detect-Virtualization-0.106-1.fc20
perl-Sys-Detect-Virtualization-0.106-1.fc20 has been pushed to the Fedora 20 testing repository.
perl-Sys-Detect-Virtualization-0.106-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Sys-Detect-Virtualization-0.106-1.el6
perl-Sys-Detect-Virtualization-0.106-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Sys-Detect-Virtualization-0.106-1.el6 has been pushed to the Fedora EPEL 6 stable repository.