Created attachment 890227 [details] vdsm and engine logs Description of problem: Version-Release number of selected component (if applicable):rhevm-3.4.0-0.12.beta2.el6ev.noarch vdsm-4.14.6-0.1.beta3.el6ev.x86_64 How reproducible: 1/1 takes very long Steps to Reproduce: 1. Create vm with 3 disks (2 thin, 1 preallocated) 2. Free space displays 135G but actually should be less (around 115G) as the free space is updated slowly. 3. Selected to create a preallocated disk of 125G (actual space should be around 115G) 3. No Warning is displayed. The user is allowed to create a new disk exceeding the free space limitation Actual results: The create disk operation was started and failed after 1 hour and 40 min Expected results: The operation should not have been allowed as there was not enough disk space available. Additional info: isk takes too long to create: 27/4/2014 --------------------------------------------------------------- engine=========== 2014-04-27 10:49:33,657 INFO [org.ovirt.engine.core.bll.AddDiskCommand] (ajp-/127.0.0.1:8702-6) [5047e196] Lock Acquired to object EngineLock [exclusiveLocks= , sharedLocks= key: 4be5ee20-c3a1-45b0-932d-ea6203cc8762 value: VM 2014-04-27 10:49:33,687 INFO [org.ovirt.engine.core.bll.AddDiskCommand] (ajp-/127.0.0.1:8702-6) [5047e196] Running command: AddDiskCommand internal: false. Entities affected : ID: 4be5ee20-c3a1-45b0-932d-ea6203cc8762 Type: VM, ID: 11031344-4f1a-452f-bca8-8e9c6b68596b Type: Storage 2014-04-27 10:49:34,529 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp-/127.0.0.1:8702-6) [4d572807] Correlation ID: 5047e196, Job ID: 50a581b4-b25b-47bd-bef9-98f7b359fb49, Call Stack: null, Custom Event ID: -1, Message: Add-Disk operation of test4_Disk6 was initiated on VM test4 by admin. 2014-04-27 12:25:35,816 ERROR [org.ovirt.engine.core.bll.AddDiskCommand] (org.ovirt.thread.pool-4-thread-20) [5047e196] Ending command with failure: org.ovirt.engine.core.bll.AddDiskCommand 2014-04-27 12:25:35,923 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.pool-4-thread-20) Correlation ID: 5047e196, Job ID: 50a581b4-b25b-47bd-bef9-98f7b359fb49, Call Stack: null, Custom Event ID: -1, Message: Operation Add-Disk failed to complete. q "aaa" 31L, 2220C
Correction: Description: Preallocated disk creation is allowed in excess of free space limitation when adding a disk to a virtual machine
All storage checks are done according to the current database state. This is by-design.
If it is not a bug than it is a great RFE, from user perspective, it make sense to see the free space left and aviod such failure. Sean?
Agreed, Sean
Talked to Sean. A CDA based on the database's info is implemented in bug 1053704. Anything else would be moving an existing race from one place to another, and adding unwarranted risk. *** This bug has been marked as a duplicate of bug 1053704 ***