Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg2vdr.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg2vdr-0.1.0-1.20130322git324f392.fc20.src.rpm Description: This plugin is used to retrieve EPG data into the VDR. The EPG data was loaded from a mysql database. Fedora Account System Username: martinkg rpmlint vdr-epg2vdr-0.1.0-1.20130322git324f392.fc20.x86_64.rpm vdr-epg2vdr.x86_64: W: spelling-error %description -l en_US mysql -> myself vdr-epg2vdr.x86_64: W: incoherent-version-in-changelog 0.6.0-1.20130322git324f392 ['0.1.0-1.20130322git324f392.fc20', '0.1.0-1.20130322git324f392'] vdr-epg2vdr.x86_64: W: unstripped-binary-or-object /usr/lib64/vdr/libvdr-epg2vdr.so.2.0.0 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg2vdr.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg2vdr-0.1.0-2.20130322git324f392.fc20.src.rpm don't know how to solve the rpmlint isssue: vdr-epg2vdr.x86_64: W: unstripped-binary-or-object /usr/lib64/vdr/libvdr-epg2vdr.so.2.0.0 %changelog * Fri Apr 25 2014 Martin Gansser <martinkg> - 0.1.0-2.20130322git324f392 - corrected version numbering in %%changelog - added CXXFLAGS - added openssl-devel as requirement - added mariadb-devel as requirement - added libuuid-devel as requirement
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg2vdr.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg2vdr-0.1.0-3.20130322git324f392.fc20.src.rpm %changelog * Fri Apr 25 2014 Martin Gansser <martinkg> - 0.1.0-3.20130322git324f392 - added permission fix to solve unstripped-binary-or-object warning # rpmlint vdr-epg2vdr-0.1.0-3.20130322git324f392.fc20.x86_64.rpm vdr-epg2vdr.x86_64: W: spelling-error %description -l en_US mysql -> myself 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # rpmlint vdr-epg2vdr-debuginfo-0.1.0-3.20130322git324f392.fc20.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Hi Mukundan, you are welcome to do the review.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg2vdr.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg2vdr-0.1.0-4.20130322git324f392.fc20.src.rpm %changelog * Fri May 02 2014 Martin Gansser <martinkg> - 0.1.0-4.20130322git324f392 - Fix patch path - Fix bogus date in %%changelog - Fix comments please note i've created further more 2 rpm packages for vdr. VDR EPG Daemon plugin: https://bugzilla.redhat.com/show_bug.cgi?id=1093407 epgd - a EPG daemon which fetch the EPG and additional data from various sources (like epgdata, eplists.constabel.net, ...) and provide it to the epg2vdr plugin via a MySQL database. The epgd get the EPG from the sources by plugins. A plugin for epgdata is contained. Scraper2VDR plugin: https://bugzilla.redhat.com/show_bug.cgi?id=1093408 scraper2vdr acts as client and provides scraped metadata for tvshows and movies from epgd to other plugins via its service interface. The plugin cares about caching the images locally and also cleans up the images if not longer needed.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-epg2vdr.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-epg2vdr-0.1.0-5.20130322git324f392.fc20.src.rpm changelog * Sat May 03 2014 Martin Gansser <martinkg> - 0.1.0-5.20130322git324f392 - fixed description
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1093410-vdr- epg2vdr/licensecheck.txt ---> This looks fine to me. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. http://koji.fedoraproject.org/koji/taskinfo?taskID=6814388 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vdr-epg2vdr-0.1.0-5.20130322git324f392.fc21.x86_64.rpm vdr-epg2vdr-0.1.0-5.20130322git324f392.fc21.src.rpm vdr-epg2vdr.x86_64: W: spelling-error Summary(en_US) mysql -> myself vdr-epg2vdr.x86_64: W: spelling-error %description -l en_US mysql -> myself vdr-epg2vdr.src: W: spelling-error Summary(en_US) mysql -> myself vdr-epg2vdr.src: W: spelling-error %description -l en_US mysql -> myself vdr-epg2vdr.src: W: file-size-mismatch vdr-epg2vdr-makefile.patch = 1195, http://projects.vdr-developer.org/attachments/1692/vdr-epg2vdr-makefile.patch = 7029 ---> Patch looks fine. 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vdr-epg2vdr vdr-epg2vdr.x86_64: W: spelling-error Summary(en_US) mysql -> myself vdr-epg2vdr.x86_64: W: spelling-error %description -l en_US mysql -> myself 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- vdr-epg2vdr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_18)(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) vdr(abi)(x86-64) Provides -------- vdr-epg2vdr: libvdr-epg2vdr.so.2.0.6()(64bit) vdr-epg2vdr vdr-epg2vdr(x86-64) Source checksums ---------------- http://projects.vdr-developer.org/git/vdr-plugin-epg2vdr.git/snapshot/vdr-plugin-epg2vdr-324f3928b068255f0c4bf6ed0a575485f5ead1c4.tar.bz2 : CHECKSUM(SHA256) this package : a36636205f17ad7de2d7d709585785002a9befe39c1a457ac8a62ad0bb3a78b2 CHECKSUM(SHA256) upstream package : a36636205f17ad7de2d7d709585785002a9befe39c1a457ac8a62ad0bb3a78b2 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1093410 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG I have no issues. Package approved.
@Mukundan Thanks for the review.
No SCM request found.
New Package SCM Request ======================= Package Name: vdr-epg2vdr Short Description: A plugin to retrieve EPG data from a mysql database into VDR Owners: martinkg Branches: f20 f21 InitialCC:
Git done (by process-git-requests). note f21 is not yet branched so there is no f21 branch
vdr-epg2vdr-0.1.0-5.20130322git324f392.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg2vdr-0.1.0-5.20130322git324f392.fc20
vdr-epg2vdr has been built successfully on fc20 and fc21.
vdr-epg2vdr-0.1.8-1.20140507git866f08d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-epg2vdr-0.1.8-1.20140507git866f08d.fc20